Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 654313002: Auto-compare GrProcessors' texture accesses in isEqual(). (Closed)

Created:
6 years, 2 months ago by bsalomon
Modified:
6 years, 2 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@xformcomp
Visibility:
Public.

Description

Auto-compare GrProcessors' texture accesses in isEqual(). R=joshualitt@google.com Committed: https://skia.googlesource.com/skia/+/420d7e9a79358908850c74192b4949375563449a

Patch Set 1 #

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -94 lines) Patch
M include/gpu/GrFragmentProcessor.h View 1 chunk +5 lines, -9 lines 0 comments Download
M include/gpu/GrGeometryProcessor.h View 1 chunk +2 lines, -8 lines 0 comments Download
M include/gpu/GrProcessor.h View 3 chunks +3 lines, -4 lines 0 comments Download
M src/core/SkXfermode.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/SkArithmeticMode.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/SkColorCubeFilter.cpp View 2 chunks +1 line, -6 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/SkLumaColorFilter.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/effects/SkTableColorFilter.cpp View 2 chunks +1 line, -5 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M src/gpu/GrProcessor.cpp View 1 chunk +10 lines, -4 lines 0 comments Download
M src/gpu/effects/GrBicubicEffect.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/effects/GrConvolutionEffect.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/effects/GrCustomCoordsTextureEffect.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.cpp View 1 3 chunks +3 lines, -6 lines 0 comments Download
M src/gpu/effects/GrMatrixConvolutionEffect.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.h View 1 chunk +1 line, -4 lines 0 comments Download
M src/gpu/effects/GrSingleTextureEffect.h View 1 chunk +0 lines, -8 lines 0 comments Download
M src/gpu/effects/GrTextureDomain.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/effects/GrYUVtoRGBEffect.cpp View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
bsalomon
6 years, 2 months ago (2014-10-15 20:02:53 UTC) #1
joshualitt
On 2014/10/15 20:02:53, bsalomon wrote: lgtm
6 years, 2 months ago (2014-10-16 14:54:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/654313002/20001
6 years, 2 months ago (2014-10-16 15:20:20 UTC) #4
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 16:18:14 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 420d7e9a79358908850c74192b4949375563449a

Powered by Google App Engine
This is Rietveld 408576698