src/effects/SkLightingImageFilter.cpp - Issue 654313002: Auto-compare GrProcessors' texture accesses in isEqual().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkLightingImageFilter.cpp

Issue 654313002: Auto-compare GrProcessors' texture accesses in isEqual(). (Closed) Base URL: https://skia.googlesource.com/skia.git@xformcomp

Patch Set: update Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkLightingImageFilter.cpp

diff --git a/src/effects/SkLightingImageFilter.cpp b/src/effects/SkLightingImageFilter.cpp

index 0e063d95c818b1b59b410741385c0838b53189e1..24bfbbd56ef05f3a2393d371b13dc437c6755a9e 100644

--- a/src/effects/SkLightingImageFilter.cpp

+++ b/src/effects/SkLightingImageFilter.cpp

@@ -1304,8 +1304,7 @@ GrLightingEffect::~GrLightingEffect() {

bool GrLightingEffect::onIsEqual(const GrFragmentProcessor& sBase) const {

const GrLightingEffect& s = sBase.cast<GrLightingEffect>();

- return this->texture(0) == s.texture(0) &&

- fLight->isEqual(*s.fLight) &&

+ return fLight->isEqual(*s.fLight) &&

fSurfaceScale == s.fSurfaceScale;

}

« no previous file with comments | « src/effects/SkDisplacementMapEffect.cpp ('k') | src/effects/SkLumaColorFilter.cpp » ('j') | no next file with comments »