src/gpu/effects/GrConvolutionEffect.cpp - Issue 654313002: Auto-compare GrProcessors' texture accesses in isEqual().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/effects/GrConvolutionEffect.cpp

Issue 654313002: Auto-compare GrProcessors' texture accesses in isEqual(). (Closed) Base URL: https://skia.googlesource.com/skia.git@xformcomp

Patch Set: update Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/effects/GrConvolutionEffect.cpp

diff --git a/src/gpu/effects/GrConvolutionEffect.cpp b/src/gpu/effects/GrConvolutionEffect.cpp

index 9776a2af5f67e65eb7e05848541cc29bfc3b3813..310e531affefd0aa38781cb4d6de51f298e94291 100644

--- a/src/gpu/effects/GrConvolutionEffect.cpp

+++ b/src/gpu/effects/GrConvolutionEffect.cpp

@@ -202,8 +202,7 @@ const GrBackendFragmentProcessorFactory& GrConvolutionEffect::getFactory() const

bool GrConvolutionEffect::onIsEqual(const GrFragmentProcessor& sBase) const {

const GrConvolutionEffect& s = sBase.cast<GrConvolutionEffect>();

- return (this->texture(0) == s.texture(0) &&

- this->radius() == s.radius() &&

+ return (this->radius() == s.radius() &&

this->direction() == s.direction() &&

this->useBounds() == s.useBounds() &&

0 == memcmp(fBounds, s.fBounds, sizeof(fBounds)) &&