src/gpu/effects/GrMatrixConvolutionEffect.cpp - Issue 654313002: Auto-compare GrProcessors' texture accesses in isEqual().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/effects/GrMatrixConvolutionEffect.cpp

Issue 654313002: Auto-compare GrProcessors' texture accesses in isEqual(). (Closed) Base URL: https://skia.googlesource.com/skia.git@xformcomp

Patch Set: update Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/effects/GrMatrixConvolutionEffect.cpp

diff --git a/src/gpu/effects/GrMatrixConvolutionEffect.cpp b/src/gpu/effects/GrMatrixConvolutionEffect.cpp

index 1f982672c4d5dc3bc7a0a47bdd010d8f2bd8e5c2..07a24a34776e7bbd76067b1b6925a777db51ef6c 100644

--- a/src/gpu/effects/GrMatrixConvolutionEffect.cpp

+++ b/src/gpu/effects/GrMatrixConvolutionEffect.cpp

@@ -178,8 +178,7 @@ const GrBackendFragmentProcessorFactory& GrMatrixConvolutionEffect::getFactory()

bool GrMatrixConvolutionEffect::onIsEqual(const GrFragmentProcessor& sBase) const {

const GrMatrixConvolutionEffect& s = sBase.cast<GrMatrixConvolutionEffect>();

- return this->texture(0) == s.texture(0) &&

- fKernelSize == s.kernelSize() &&

+ return fKernelSize == s.kernelSize() &&

!memcmp(fKernel, s.kernel(),

fKernelSize.width() * fKernelSize.height() * sizeof(float)) &&

fGain == s.gain() &&