src/gpu/effects/GrCustomCoordsTextureEffect.cpp - Issue 654313002: Auto-compare GrProcessors' texture accesses in isEqual().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/effects/GrCustomCoordsTextureEffect.cpp

Issue 654313002: Auto-compare GrProcessors' texture accesses in isEqual(). (Closed) Base URL: https://skia.googlesource.com/skia.git@xformcomp

Patch Set: update Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/effects/GrCustomCoordsTextureEffect.cpp

diff --git a/src/gpu/effects/GrCustomCoordsTextureEffect.cpp b/src/gpu/effects/GrCustomCoordsTextureEffect.cpp

index 896bfa59321127712281d88774ce59a78cbec933..8c7555e8ff08589f6a68ed84750078a838b53d3a 100644

--- a/src/gpu/effects/GrCustomCoordsTextureEffect.cpp

+++ b/src/gpu/effects/GrCustomCoordsTextureEffect.cpp

@@ -68,8 +68,7 @@ GrCustomCoordsTextureEffect::GrCustomCoordsTextureEffect(GrTexture* texture,

}

bool GrCustomCoordsTextureEffect::onIsEqual(const GrGeometryProcessor& other) const {

- const GrCustomCoordsTextureEffect& cte = other.cast<GrCustomCoordsTextureEffect>();

- return fTextureAccess == cte.fTextureAccess;

+ return true;

}

void GrCustomCoordsTextureEffect::onComputeInvariantOutput(InvariantOutput* inout) const {