Cleanup: Better constify some strings in chrome.

Cleanup: Better constify some strings in chrome.

Also fix passing by non-const reference in chromedriver.

Committed: https://crrev.com/84fcd2a6a6b037da6552b21af95fab268bc05a6f
Cr-Commit-Position: refs/heads/master@{#300629}

[Lei Zhang, 2014-10-22 00:37:12]

thestig@chromium.org changed reviewers:
+ stgao@chromium.org

[Lei Zhang, 2014-10-22 00:37:52]

Hi, if you can take a look at the chromedriver changes, and also stamp the rest
of the CL, which is just making things more const.

[stgao, 2014-10-22 01:40:16]

lgtm after compile error is fixed.

Many thanks for the cleanup.

https://codereview.chromium.org/635623003/diff/40001/chrome/tools/mac_helpers...
File chrome/tools/mac_helpers/infoplist_strings_util.mm (right):

https://codereview.chromium.org/635623003/diff/40001/chrome/tools/mac_helpers...
chrome/tools/mac_helpers/infoplist_strings_util.mm:242: short_name_id_str =
"IDS_SHORT_HELPER_NAME";
|name_id_str| and |short_name_id_str| are assigned new value here. And it seems
causing the compile error in
http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/71759

[Lei Zhang, 2014-10-22 02:24:07]

Thanks for the quick review.

https://codereview.chromium.org/635623003/diff/40001/chrome/tools/mac_helpers...
File chrome/tools/mac_helpers/infoplist_strings_util.mm (right):

https://codereview.chromium.org/635623003/diff/40001/chrome/tools/mac_helpers...
chrome/tools/mac_helpers/infoplist_strings_util.mm:242: short_name_id_str =
"IDS_SHORT_HELPER_NAME";
On 2014/10/22 01:40:16, Shuotao wrote:
> |name_id_str| and |short_name_id_str| are assigned new value here. And it
seems
> causing the compile error in
>
http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/71759

Reverted.

[Lei Zhang, 2014-10-22 02:24:17]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-10-22 02:25:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/635623003/60001

[commit-bot: I haz the power, 2014-10-22 04:16:29]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-10-22 04:17:34]

Patchset 4 (id:??) landed as
https://crrev.com/84fcd2a6a6b037da6552b21af95fab268bc05a6f
Cr-Commit-Position: refs/heads/master@{#300629}