chrome/test/chromedriver/chrome/heap_snapshot_taker.cc - Issue 635623003: Cleanup: Better constify some strings in chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/heap_snapshot_taker.cc

Issue 635623003: Cleanup: Better constify some strings in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix mac Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/chrome/heap_snapshot_taker.cc

diff --git a/chrome/test/chromedriver/chrome/heap_snapshot_taker.cc b/chrome/test/chromedriver/chrome/heap_snapshot_taker.cc

index 996d78d09508973cac8d92202428f733ba58fc07..0f119e0f1c9a8530c745591df79f26c1139efaf9 100644

--- a/chrome/test/chromedriver/chrome/heap_snapshot_taker.cc

+++ b/chrome/test/chromedriver/chrome/heap_snapshot_taker.cc

@@ -43,7 +43,7 @@ Status HeapSnapshotTaker::TakeSnapshot(scoped_ptr<base::Value>* snapshot) {

Status HeapSnapshotTaker::TakeSnapshotInternal() {

base::DictionaryValue params;

- const char* kMethods[] = {

+ const char* const kMethods[] = {

"Debugger.enable",

"HeapProfiler.collectGarbage",

"HeapProfiler.takeHeapSnapshot"