chrome/renderer/principals_extension_bindings.cc - Issue 635623003: Cleanup: Better constify some strings in chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/principals_extension_bindings.cc

Issue 635623003: Cleanup: Better constify some strings in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix mac Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/principals_extension_bindings.cc

diff --git a/chrome/renderer/principals_extension_bindings.cc b/chrome/renderer/principals_extension_bindings.cc

index f862c41037695e678fbfa796651b9a1ffa41afcb..9118c8d63dec44f60409fca235bbe61c1cd45a3b 100644

--- a/chrome/renderer/principals_extension_bindings.cc

+++ b/chrome/renderer/principals_extension_bindings.cc

@@ -37,8 +37,8 @@ class PrincipalsExtensionWrapper : public v8::Extension {

DISALLOW_COPY_AND_ASSIGN(PrincipalsExtensionWrapper);

};

-const char* kPrincipalsExtensionName = "v8/Principals";

-const char* kPrincipalsExtensionCode =

+const char kPrincipalsExtensionName[] = "v8/Principals";

+const char kPrincipalsExtensionCode[] =

"var chrome;"

"if (!chrome)"

" chrome = {};"