chrome/renderer/safe_browsing/malware_dom_details_browsertest.cc - Issue 635623003: Cleanup: Better constify some strings in chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/safe_browsing/malware_dom_details_browsertest.cc

Issue 635623003: Cleanup: Better constify some strings in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix mac Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/safe_browsing/malware_dom_details_browsertest.cc

diff --git a/chrome/renderer/safe_browsing/malware_dom_details_browsertest.cc b/chrome/renderer/safe_browsing/malware_dom_details_browsertest.cc

index 7ea474cb2247925cda4782ce683badc15cb41075..e4ef1e649a1f3435715c1438ee384af09b3cb70b 100644

--- a/chrome/renderer/safe_browsing/malware_dom_details_browsertest.cc

+++ b/chrome/renderer/safe_browsing/malware_dom_details_browsertest.cc

@@ -18,7 +18,7 @@ TEST_F(MalwareDOMDetailsTest, Everything) {

// debug build takes a while.

details->kMaxNodes = 50;

- const char* urlprefix = "data:text/html;charset=utf-8,";

+ const char urlprefix[] = "data:text/html;charset=utf-8,";

{ // An page with an internal script

std::string html = "<html><head><script></script></head></html>";

@@ -127,5 +127,4 @@ TEST_F(MalwareDOMDetailsTest, Everything) {

details->ExtractResources(&params);

ASSERT_EQ(51u, params.size());

}