chrome/test/chromedriver/chrome/device_manager.h - Issue 635623003: Cleanup: Better constify some strings in chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/device_manager.h

Issue 635623003: Cleanup: Better constify some strings in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix mac Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/chrome/device_manager.h

diff --git a/chrome/test/chromedriver/chrome/device_manager.h b/chrome/test/chromedriver/chrome/device_manager.h

index 6b812c545bdd42093c51a2bdc0ab40eb1b313286..d27aa50719f9371d5eba70c90ca03fd66016df78 100644

--- a/chrome/test/chromedriver/chrome/device_manager.h

+++ b/chrome/test/chromedriver/chrome/device_manager.h

@@ -40,8 +40,8 @@ class Device {

Status ForwardDevtoolsPort(const std::string& package,

const std::string& process,

- std::string& device_socket,

- int port);

+ int port,

+ std::string* device_socket);

const std::string serial_;

std::string active_package_;