Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5690)

Unified Diff: chrome/test/chromedriver/window_commands.cc

Issue 635623003: Cleanup: Better constify some strings in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix mac Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/util_unittest.cc ('k') | chrome/tools/mac_helpers/infoplist_strings_util.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/window_commands.cc
diff --git a/chrome/test/chromedriver/window_commands.cc b/chrome/test/chromedriver/window_commands.cc
index aa07400849a81f6fdd8a2e875d557e0794bb422f..930456ee9fd097836428ffb39aba20dd394e6537 100644
--- a/chrome/test/chromedriver/window_commands.cc
+++ b/chrome/test/chromedriver/window_commands.cc
@@ -343,7 +343,7 @@ Status ExecuteSwitchToFrame(
return Status(kUnknownError, "fail to locate the sub frame element");
std::string chrome_driver_id = GenerateId();
- const char* kSetFrameIdentifier =
+ const char kSetFrameIdentifier[] =
"function(frame, id) {"
" frame.setAttribute('cd_frame_id_', id);"
"}";
@@ -373,7 +373,7 @@ Status ExecuteGetTitle(
WebView* web_view,
const base::DictionaryValue& params,
scoped_ptr<base::Value>* value) {
- const char* kGetTitleScript =
+ const char kGetTitleScript[] =
"function() {"
" if (document.title)"
" return document.title;"
@@ -389,7 +389,7 @@ Status ExecuteGetPageSource(
WebView* web_view,
const base::DictionaryValue& params,
scoped_ptr<base::Value>* value) {
- const char* kGetPageSource =
+ const char kGetPageSource[] =
"function() {"
" return new XMLSerializer().serializeToString(document);"
"}";
« no previous file with comments | « chrome/test/chromedriver/util_unittest.cc ('k') | chrome/tools/mac_helpers/infoplist_strings_util.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698