Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Unified Diff: chrome/test/chromedriver/capabilities.cc

Issue 635623003: Cleanup: Better constify some strings in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix mac Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/base/tracing_browsertest.cc ('k') | chrome/test/chromedriver/chrome/device_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/capabilities.cc
diff --git a/chrome/test/chromedriver/capabilities.cc b/chrome/test/chromedriver/capabilities.cc
index 9e403af735dd5cf74416fec697a716c68dd03fc9..548b95156ddc13e244371754f26e364b9ab8d5c9 100644
--- a/chrome/test/chromedriver/capabilities.cc
+++ b/chrome/test/chromedriver/capabilities.cc
@@ -210,7 +210,7 @@ Status ParseProxy(const base::Value& option, Capabilities* capabilities) {
} else if (proxy_type == "autodetect") {
capabilities->switches.SetSwitch("proxy-auto-detect");
} else if (proxy_type == "manual") {
- const char* proxy_servers_options[][2] = {
+ const char* const proxy_servers_options[][2] = {
{"ftpProxy", "ftp"}, {"httpProxy", "http"}, {"sslProxy", "https"}};
const base::Value* option_value = NULL;
std::string proxy_servers;
@@ -354,8 +354,8 @@ Status ParsePerfLoggingPrefs(const base::Value& option,
Status status = parser_map[it.key()].Run(it.value(), capabilities);
if (status.IsError())
return Status(kUnknownError, "cannot parse " + it.key(), status);
- }
- return Status(kOk);
+ }
+ return Status(kOk);
}
Status ParseChromeOptions(
« no previous file with comments | « chrome/test/base/tracing_browsertest.cc ('k') | chrome/test/chromedriver/chrome/device_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698