Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5087)

Unified Diff: chrome/installer/util/master_preferences_unittest.cc

Issue 635623003: Cleanup: Better constify some strings in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix mac Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/service_process_util_win.cc ('k') | chrome/renderer/chrome_content_renderer_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/master_preferences_unittest.cc
diff --git a/chrome/installer/util/master_preferences_unittest.cc b/chrome/installer/util/master_preferences_unittest.cc
index 6c162d79773c5c6834309cb31d9a8e18fef2f8dc..56c7f8c1e252db758d611475047ae26437780253 100644
--- a/chrome/installer/util/master_preferences_unittest.cc
+++ b/chrome/installer/util/master_preferences_unittest.cc
@@ -80,7 +80,7 @@ TEST_F(MasterPreferencesTest, ParseDistroParams) {
installer::MasterPreferences prefs(prefs_file());
EXPECT_TRUE(prefs.read_from_file());
- const char* expected_true[] = {
+ const char* const expected_true[] = {
installer::master_preferences::kDistroImportSearchPref,
installer::master_preferences::kDistroImportHistoryPref,
installer::master_preferences::kDistroImportBookmarksPref,
@@ -153,7 +153,7 @@ TEST_F(MasterPreferencesTest, ParseMissingDistroParams) {
EXPECT_EQ(value, expected_bool[i].expected_value) << expected_bool[i].name;
}
- const char* missing_bools[] = {
+ const char* const missing_bools[] = {
installer::master_preferences::kDistroImportHomePagePref,
installer::master_preferences::kDoNotRegisterForUpdateLaunch,
installer::master_preferences::kMakeChromeDefault,
« no previous file with comments | « chrome/common/service_process_util_win.cc ('k') | chrome/renderer/chrome_content_renderer_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698