chrome/test/chromedriver/chrome/web_view_impl.cc - Issue 635623003: Cleanup: Better constify some strings in chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/web_view_impl.cc

Issue 635623003: Cleanup: Better constify some strings in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix mac Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/chrome/web_view_impl.cc

diff --git a/chrome/test/chromedriver/chrome/web_view_impl.cc b/chrome/test/chromedriver/chrome/web_view_impl.cc

index f1ab9b4d64347f0f6e47bc7dda88b0d5763b902c..28577ae93c4388adf786bd8dbc5a45e980741ed6 100644

--- a/chrome/test/chromedriver/chrome/web_view_impl.cc

+++ b/chrome/test/chromedriver/chrome/web_view_impl.cc

@@ -510,7 +510,7 @@ Status WebViewImpl::CallAsyncFunctionInternal(const std::string& frame,

if (status.IsError())

return status;

- const char* kDocUnloadError = "document unloaded while waiting for result";

+ const char kDocUnloadError[] = "document unloaded while waiting for result";

std::string kQueryResult = base::StringPrintf(

"function() {"

" var info = document.$chrome_asyncScriptInfo;"