Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2269)

Unified Diff: chrome/renderer/plugins/plugin_uma.cc

Issue 635623003: Cleanup: Better constify some strings in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix mac Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/plugins/plugin_uma.h ('k') | chrome/renderer/principals_extension_bindings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/plugins/plugin_uma.cc
diff --git a/chrome/renderer/plugins/plugin_uma.cc b/chrome/renderer/plugins/plugin_uma.cc
index a66d26b9380194ca11eb2c724effa03f98244af4..4040f6305332f036d4a814918e575a0ef7b66033 100644
--- a/chrome/renderer/plugins/plugin_uma.cc
+++ b/chrome/renderer/plugins/plugin_uma.cc
@@ -23,15 +23,15 @@ const char kQuickTimeType[] = "video/quicktime";
// Arrays containing file extensions connected with specific plugins.
// Note: THE ARRAYS MUST BE SORTED BECAUSE BINARY SEARCH IS USED ON THEM!
-const char* kWindowsMediaPlayerExtensions[] = {".asx"};
+const char* const kWindowsMediaPlayerExtensions[] = {".asx"};
-const char* kRealPlayerExtensions[] = {".ra", ".ram", ".rm",
- ".rmm", ".rmp", ".rpm"};
+const char* const kRealPlayerExtensions[] = {".ra", ".ram", ".rm",
+ ".rmm", ".rmp", ".rpm"};
-const char* kQuickTimeExtensions[] = {".moov", ".mov", ".qif",
- ".qt", ".qti", ".qtif"};
+const char* const kQuickTimeExtensions[] = {".moov", ".mov", ".qif",
+ ".qt", ".qti", ".qtif"};
-const char* kShockwaveFlashExtensions[] = {".spl", ".swf"};
+const char* const kShockwaveFlashExtensions[] = {".spl", ".swf"};
} // namespace.
@@ -87,7 +87,7 @@ bool PluginUMAReporter::CompareCStrings(const char* first, const char* second) {
return strcmp(first, second) < 0;
}
-bool PluginUMAReporter::CStringArrayContainsCString(const char** array,
+bool PluginUMAReporter::CStringArrayContainsCString(const char* const* array,
size_t array_size,
const char* str) {
return std::binary_search(array, array + array_size, str, CompareCStrings);
« no previous file with comments | « chrome/renderer/plugins/plugin_uma.h ('k') | chrome/renderer/principals_extension_bindings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698