Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 595073002: Replace forward_dependent_configs with public_deps (Closed)

Created:
6 years, 3 months ago by brettw
Modified:
6 years, 3 months ago
Reviewers:
jamesr
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, zea+watch_chromium.org, viettrungluu+watch_chromium.org, hguihot+watch_chromium.org, skal, browser-components-watch_chromium.org, yzshen+watch_chromium.org, vikasa, Ilya Sherman, mkwst+moarreviews-shell_chromium.org, mkwst+watchlist_chromium.org, mikhal+watch_chromium.org, tim+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, benquan, ben+mojo_chromium.org, chromoting-reviews_chromium.org, jam, abarth-chromium, darin-cc_chromium.org, rouslan+autofillwatch_chromium.org, chromium-apps-reviews_chromium.org, tdresser+watch_chromium.org, erikwright+watch_chromium.org, ozone-reviews_chromium.org, hubbe+watch_chromium.org, Dane Wallinga, imcheng+watch_chromium.org, jzern, jasonroberts+watch_google.com, haitaol+watch_chromium.org, miu+watch_chromium.org, feature-media-reviews_chromium.org, dmikurube+memory_chromium.org, kalyank, piman+watch_chromium.org, gcasto+watchlist_chromium.org, darin (slow to review), jochen+watch_chromium.org, maniscalco+watch_chromium.org, hclam+watch_chromium.org, wfh+watch_chromium.org, avayvod+watch_chromium.org, pwestin+watch_google.com, Aaron Boodman, ben+ash_chromium.org, dyu1, urvang (Google), estade+watch_chromium.org, cc-bugs_chromium.org, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replace forward_dependent_configs with public_deps This is the new name. It has the same meaning but additionally with a "you can use the headers" permission. Rename direct_dependent_configs to public_configs. This is the new name with identical meaning. TBR=jamesr Committed: https://crrev.com/e5389527466d390b5653724a069008b9f1edcd5c Cr-Commit-Position: refs/heads/master@{#296302}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+305 lines, -424 lines) Patch
M ash/BUILD.gn View 5 chunks +9 lines, -14 lines 0 comments Download
M base/allocator/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M base/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M breakpad/BUILD.gn View 4 chunks +5 lines, -5 lines 0 comments Download
M build/config/android/rules.gni View 3 chunks +7 lines, -7 lines 0 comments Download
M build/secondary/testing/gmock/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M build/secondary/testing/gtest/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M build/secondary/third_party/android_tools/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M build/secondary/third_party/cacheinvalidation/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M build/secondary/third_party/flac/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M build/secondary/third_party/freetype/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M build/secondary/third_party/google_toolbox_for_mac/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M build/secondary/third_party/icu/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M build/secondary/third_party/leveldatabase/BUILD.gn View 2 chunks +4 lines, -3 lines 0 comments Download
M build/secondary/third_party/libjpeg_turbo/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M build/secondary/third_party/libsrtp/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M build/secondary/third_party/nss/BUILD.gn View 6 chunks +9 lines, -11 lines 0 comments Download
M build/secondary/third_party/openmax_dl/dl/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M build/secondary/tools/grit/grit_rule.gni View 1 chunk +1 line, -1 line 0 comments Download
M cc/BUILD.gn View 3 chunks +4 lines, -9 lines 0 comments Download
M cc/blink/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/BUILD.gn View 8 chunks +16 lines, -25 lines 0 comments Download
M chrome/browser/extensions/BUILD.gn View 4 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 8 chunks +12 lines, -24 lines 0 comments Download
M chrome/test/BUILD.gn View 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/utility/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
M components/autofill/content/browser/BUILD.gn View 3 chunks +3 lines, -5 lines 0 comments Download
M components/autofill/core/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/crash/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/dom_distiller/content/BUILD.gn View 2 chunks +3 lines, -5 lines 0 comments Download
M components/dom_distiller/core/BUILD.gn View 1 chunk +4 lines, -7 lines 0 comments Download
M components/infobars/core/BUILD.gn View 1 chunk +3 lines, -4 lines 0 comments Download
M components/invalidation/BUILD.gn View 2 chunks +3 lines, -5 lines 0 comments Download
M components/metrics/BUILD.gn View 5 chunks +13 lines, -15 lines 0 comments Download
M components/omnibox/BUILD.gn View 2 chunks +3 lines, -5 lines 0 comments Download
M components/password_manager/core/browser/BUILD.gn View 2 chunks +4 lines, -6 lines 0 comments Download
M content/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M content/common/BUILD.gn View 2 chunks +4 lines, -7 lines 0 comments Download
M content/public/browser/BUILD.gn View 3 chunks +6 lines, -7 lines 0 comments Download
M content/public/child/BUILD.gn View 1 chunk +2 lines, -3 lines 0 comments Download
M content/public/common/BUILD.gn View 3 chunks +5 lines, -6 lines 0 comments Download
M content/public/plugin/BUILD.gn View 1 chunk +2 lines, -3 lines 0 comments Download
M content/public/renderer/BUILD.gn View 1 chunk +2 lines, -3 lines 0 comments Download
M content/public/utility/BUILD.gn View 1 chunk +2 lines, -3 lines 0 comments Download
M content/shell/BUILD.gn View 2 chunks +3 lines, -4 lines 0 comments Download
M content/test/BUILD.gn View 3 chunks +4 lines, -5 lines 0 comments Download
M crypto/BUILD.gn View 1 chunk +5 lines, -5 lines 0 comments Download
M dbus/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M device/media_transfer_protocol/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M extensions/generated_extensions_api.gni View 1 chunk +1 line, -1 line 0 comments Download
M gin/BUILD.gn View 2 chunks +7 lines, -12 lines 0 comments Download
M google_apis/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M google_apis/gcm/BUILD.gn View 2 chunks +6 lines, -6 lines 0 comments Download
M gpu/command_buffer/client/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M jingle/BUILD.gn View 4 chunks +10 lines, -6 lines 0 comments Download
M media/cast/BUILD.gn View 1 chunk +3 lines, -5 lines 0 comments Download
M media/cast/logging/proto/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M media/cast/test/proto/BUILD.gn View 1 chunk +2 lines, -5 lines 0 comments Download
M mojo/aura/BUILD.gn View 2 chunks +3 lines, -5 lines 0 comments Download
M mojo/bindings/js/BUILD.gn View 1 chunk +1 line, -3 lines 0 comments Download
M mojo/environment/BUILD.gn View 1 chunk +1 line, -5 lines 0 comments Download
M mojo/gles2/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/gles2/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/cpp/geometry/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download
M net/BUILD.gn View 6 chunks +12 lines, -16 lines 0 comments Download
M net/third_party/nss/ssl/BUILD.gn View 3 chunks +3 lines, -4 lines 0 comments Download
M ppapi/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/base/BUILD.gn View 1 chunk +6 lines, -10 lines 0 comments Download
M remoting/protocol/BUILD.gn View 2 chunks +3 lines, -5 lines 0 comments Download
M rlz/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M sdch/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M skia/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M sync/BUILD.gn View 6 chunks +6 lines, -23 lines 0 comments Download
M third_party/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/boringssl/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/cld/BUILD.gn View 2 chunks +2 lines, -6 lines 0 comments Download
M third_party/dom_distiller_js/BUILD.gn View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/expat/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/fontconfig/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/freetype2/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/iccjpeg/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/jsoncpp/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libaddressinput/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/libjingle/BUILD.gn View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/libjpeg/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libphonenumber/BUILD.gn View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/libpng/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libusb/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libwebp/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libxml/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/libxslt/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/lzma_sdk/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mesa/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/npapi/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/opus/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/protobuf/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/protobuf/proto_library.gni View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/qcms/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/re2/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/snappy/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/sqlite/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/usrsctp/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/zlib/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/generate_library_loader/generate_library_loader.gni View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/gl/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/dri/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
brettw
6 years, 3 months ago (2014-09-23 23:09:07 UTC) #2
jamesr
rslgtm (I looked at a few targets)
6 years, 3 months ago (2014-09-23 23:12:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/595073002/1
6 years, 3 months ago (2014-09-23 23:18:48 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-09-23 23:18:50 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e5389527466d390b5653724a069008b9f1edcd5c Cr-Commit-Position: refs/heads/master@{#296302}
6 years, 3 months ago (2014-09-23 23:42:51 UTC) #8
brettw
6 years, 3 months ago (2014-09-23 23:42:53 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as e538952 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698