Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Unified Diff: sync/BUILD.gn

Issue 595073002: Replace forward_dependent_configs with public_deps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « skia/BUILD.gn ('k') | third_party/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/BUILD.gn
diff --git a/sync/BUILD.gn b/sync/BUILD.gn
index 948f18a9d4512ff481e170f5858b48ce8764a41e..d5cae95e0ef3f0227717a9e21cc87a37c5fe72d6 100644
--- a/sync/BUILD.gn
+++ b/sync/BUILD.gn
@@ -472,7 +472,7 @@ static_library("test_support_sync_core") {
"util/test_unrecoverable_error_handler.h",
]
- deps = [
+ public_deps = [
"//base",
"//testing/gmock",
"//testing/gtest",
@@ -481,12 +481,6 @@ static_library("test_support_sync_core") {
defines = [ "SYNC_TEST" ]
configs += [ "//build/config/compiler:wexit_time_destructors" ]
-
- forward_dependent_configs_from = [
- "//testing/gmock",
- "//testing/gtest",
- "//sync"
- ]
}
# GYP version: sync/sync_tests.gypi:test_support_sync_internal_api
@@ -509,7 +503,7 @@ static_library("test_support_sync_internal_api") {
"internal_api/test/test_user_share.cc",
]
- deps = [
+ public_deps = [
"//base",
"//testing/gtest",
"//sync",
@@ -518,12 +512,6 @@ static_library("test_support_sync_internal_api") {
defines = [ "SYNC_TEST" ]
configs += [ "//build/config/compiler:wexit_time_destructors" ]
-
- forward_dependent_configs_from = [
- "//testing/gtest",
- "//sync",
- ":test_support_sync_core",
- ]
}
# GYP version: sync/sync_tests.gypi:test_support_sync_api
@@ -540,14 +528,9 @@ static_library("test_support_sync_api") {
"api/sync_error_factory_mock.h",
]
- deps = [
- "//testing/gmock",
- "//sync",
- ]
-
defines = [ "SYNC_TEST" ]
- forward_dependent_configs_from = [
+ public_deps = [
"//testing/gmock",
"//sync",
]
@@ -720,16 +703,16 @@ static_library("test_support_sync_testserver") {
configs += [ "//build/config/compiler:wexit_time_destructors" ]
- deps = [
+ public_deps = [
"//base",
"//net:test_support",
+ ]
+ deps = [
":sync",
# The sync test server uses Python modules generated by the sync protos.
# '../third_party/protobuf/protobuf.gyp:py_proto', # TODO(GYP)
]
-
- forward_dependent_configs_from = [ "//base", "//net:test_support" ]
}
# GYP version: sync/sync_tests.gypi:test_support_accounts_client
« no previous file with comments | « skia/BUILD.gn ('k') | third_party/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698