Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1350)

Unified Diff: gin/BUILD.gn

Issue 595073002: Replace forward_dependent_configs with public_deps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/generated_extensions_api.gni ('k') | google_apis/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/BUILD.gn
diff --git a/gin/BUILD.gn b/gin/BUILD.gn
index 22f631fa8c1445da18604bff91ecf9b20da20e99..21807ae8af6631593ce5de9ce4f4073b3213eb8d 100644
--- a/gin/BUILD.gn
+++ b/gin/BUILD.gn
@@ -58,16 +58,14 @@ component("gin") {
]
defines = [ "GIN_IMPLEMENTATION" ]
- deps = [
- "//base",
- "//base/third_party/dynamic_annotations",
- "//v8",
- ]
- forward_dependent_configs_from = [
+ public_deps = [
"//base",
"//v8",
]
+ deps = [
+ "//base/third_party/dynamic_annotations",
+ ]
}
executable("gin_shell") {
@@ -98,15 +96,12 @@ source_set("gin_test") {
"test/v8_test.h",
]
- deps = [
+ public_deps = [
":gin",
"//testing/gtest",
- "//v8",
]
-
- forward_dependent_configs_from = [
- ":gin",
- "//testing/gtest",
+ deps = [
+ "//v8",
]
}
« no previous file with comments | « extensions/generated_extensions_api.gni ('k') | google_apis/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698