Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/libxml/BUILD.gn

Issue 595073002: Replace forward_dependent_configs with public_deps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/libwebp/BUILD.gn ('k') | third_party/libxslt/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/libxml/BUILD.gn
diff --git a/third_party/libxml/BUILD.gn b/third_party/libxml/BUILD.gn
index 455c0ea35fdd5adce30acaebafebbb930fa5258f..73bb3dcfb5db24fb3730ce48968e265c6f3607f7 100644
--- a/third_party/libxml/BUILD.gn
+++ b/third_party/libxml/BUILD.gn
@@ -142,11 +142,11 @@ static_library("libxml") {
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]
- direct_dependent_configs = [ ":libxml_config" ]
- forward_dependent_configs_from = [ "//third_party/icu:icuuc" ]
-
- deps = [
+ public_configs = [ ":libxml_config" ]
+ public_deps = [
"//third_party/icu:icuuc",
+ ]
+ deps = [
"//third_party/zlib",
]
« no previous file with comments | « third_party/libwebp/BUILD.gn ('k') | third_party/libxslt/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698