components/omnibox/BUILD.gn - Issue 595073002: Replace forward_dependent_configs with public_deps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/omnibox/BUILD.gn

Issue 595073002: Replace forward_dependent_configs with public_deps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/omnibox/BUILD.gn

diff --git a/components/omnibox/BUILD.gn b/components/omnibox/BUILD.gn

index 2f56ee6beffdeeb54c4fe0e8c0d5d07697957915..f24e05d6bca6e70c53996331b28d1afbb73d80e6 100644

--- a/components/omnibox/BUILD.gn

+++ b/components/omnibox/BUILD.gn

@@ -35,9 +35,11 @@ static_library("omnibox") {

"url_prefix.h",

]

+ public_deps = [

+ "//components/metrics/proto",

+ ]

deps = [

"//base",

- "//components/metrics/proto",

"//components/resources",

"//components/search_engines",

"//components/strings",

@@ -47,10 +49,6 @@ static_library("omnibox") {

"//ui/base",

"//url",

]

- forward_dependent_configs_from = [

- "//components/metrics/proto",

- ]

}

static_library("test_support") {

« no previous file with comments | « components/metrics/BUILD.gn ('k') | components/password_manager/core/browser/BUILD.gn » ('j') | no next file with comments »