Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Unified Diff: third_party/libphonenumber/BUILD.gn

Issue 595073002: Replace forward_dependent_configs with public_deps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/libjpeg/BUILD.gn ('k') | third_party/libpng/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/libphonenumber/BUILD.gn
diff --git a/third_party/libphonenumber/BUILD.gn b/third_party/libphonenumber/BUILD.gn
index 26386a64bac43d21758c8778577920d146621ed8..22d13475be5fc88f86d5a4ddf3901e55834c4771 100644
--- a/third_party/libphonenumber/BUILD.gn
+++ b/third_party/libphonenumber/BUILD.gn
@@ -49,15 +49,16 @@ static_library("libphonenumber_without_metadata") {
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]
- direct_dependent_configs = [ ":libphonenumber_config" ]
+ public_configs = [ ":libphonenumber_config" ]
+ public_deps = [
+ ":proto",
+ ]
deps = [
":proto",
"//third_party/icu",
"//third_party/protobuf:protobuf_lite",
]
-
- forward_dependent_configs_from = [ ":proto" ]
}
# Library used by clients that includes production metadata.
@@ -70,10 +71,9 @@ static_library("libphonenumber") {
#"src/phonenumbers/metadata.cc",
]
- deps = [
+ public_deps = [
":libphonenumber_without_metadata",
]
- forward_dependent_configs_from = deps
}
# GYP version: third_party/libphonenumber/libphonenumber.gyp:libphonenumber_unittests
« no previous file with comments | « third_party/libjpeg/BUILD.gn ('k') | third_party/libpng/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698