Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: ash/BUILD.gn

Issue 595073002: Replace forward_dependent_configs with public_deps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/allocator/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/BUILD.gn
diff --git a/ash/BUILD.gn b/ash/BUILD.gn
index 2ea826fc9719414549499d1e431b57d4e0555806..12ffc9c510acefc27e6dfade39f7bab489dd0642 100644
--- a/ash/BUILD.gn
+++ b/ash/BUILD.gn
@@ -16,9 +16,11 @@ component("ash") {
defines = [ "ASH_IMPLEMENTATION" ]
- deps = [
+ public_deps = [
"//ash/resources",
"//ash/strings",
+ ]
+ deps = [
"//base",
"//base:i18n",
"//base/third_party/dynamic_annotations",
@@ -50,11 +52,6 @@ component("ash") {
"//url",
]
- forward_dependent_configs_from = [
- "//ash/resources",
- "//ash/strings",
- ]
-
if (is_win) {
sources -= [
"sticky_keys/sticky_keys_controller.cc",
@@ -134,8 +131,10 @@ component("ash_with_content") {
defines = [ "ASH_WITH_CONTENT_IMPLEMENTATION" ]
- deps = [
+ public_deps = [
":ash",
+ ]
+ deps = [
"//base",
"//base/third_party/dynamic_annotations",
"//content/public/browser",
@@ -154,18 +153,16 @@ component("ash_with_content") {
"//ui/web_dialogs",
"//url",
]
-
- forward_dependent_configs_from = [
- ":ash",
- ]
}
static_library("test_support") {
testonly = true
sources = gypi_values.ash_test_support_sources
- deps = [
+ public_deps = [
":ash",
+ ]
+ deps = [
"//ash/resources",
"//content/test:test_support",
"//skia",
@@ -179,8 +176,6 @@ static_library("test_support") {
"//ui/views:test_support",
]
- forward_dependent_configs_from = [ ":ash" ]
-
if (is_win) {
sources += [
"test/test_metro_viewer_process_host.cc",
« no previous file with comments | « no previous file | base/allocator/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698