Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Side by Side Diff: third_party/harfbuzz-ng/BUILD.gn

Issue 595073002: Replace forward_dependent_configs with public_deps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/freetype2/BUILD.gn ('k') | third_party/iccjpeg/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # The GYP build supports system harfbuzz for non-official builds when using 5 # The GYP build supports system harfbuzz for non-official builds when using
6 # pangoft2 1.31.0 or greater (which pulls it in). 6 # pangoft2 1.31.0 or greater (which pulls it in).
7 # TODO(brettw) we can consider doing this as well, although the benefit is 7 # TODO(brettw) we can consider doing this as well, although the benefit is
8 # unclear and requires shelling out to a script to check the version. 8 # unclear and requires shelling out to a script to check the version.
9 # 9 #
10 # ChromeOS uses an up-to-date system one that we have control over, so we 10 # ChromeOS uses an up-to-date system one that we have control over, so we
11 # don't want to bloat the binary more by including another copy. 11 # don't want to bloat the binary more by including another copy.
12 12
13 declare_args() { 13 declare_args() {
14 use_system_harfbuzz = is_chromeos 14 use_system_harfbuzz = is_chromeos
15 } 15 }
16 16
17 if (use_system_harfbuzz) { 17 if (use_system_harfbuzz) {
18 import("//build/config/linux/pkg_config.gni") 18 import("//build/config/linux/pkg_config.gni")
19 pkg_config("harfbuzz_pkgconfig") { 19 pkg_config("harfbuzz_pkgconfig") {
20 packages = [ "harfbuzz" ] 20 packages = [ "harfbuzz" ]
21 } 21 }
22 group("harfbuzz-ng") { 22 group("harfbuzz-ng") {
23 direct_dependent_configs = [ ":harfbuzz_pkgconfig" ] 23 public_configs = [ ":harfbuzz_pkgconfig" ]
24 } 24 }
25 25
26 } else { 26 } else {
27 config("harfbuzz-ng_config") { 27 config("harfbuzz-ng_config") {
28 include_dirs = [ "src" ] 28 include_dirs = [ "src" ]
29 } 29 }
30 30
31 source_set("harfbuzz-ng") { 31 source_set("harfbuzz-ng") {
32 sources = [ 32 sources = [
33 "src/hb-atomic-private.hh", 33 "src/hb-atomic-private.hh",
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 122
123 defines = [ 123 defines = [
124 "HAVE_OT", 124 "HAVE_OT",
125 "HAVE_ICU", 125 "HAVE_ICU",
126 "HAVE_ICU_BUILTIN", 126 "HAVE_ICU_BUILTIN",
127 "HB_NO_MT", 127 "HB_NO_MT",
128 ] 128 ]
129 129
130 configs -= [ "//build/config/compiler:chromium_code" ] 130 configs -= [ "//build/config/compiler:chromium_code" ]
131 configs += [ "//build/config/compiler:no_chromium_code" ] 131 configs += [ "//build/config/compiler:no_chromium_code" ]
132 direct_dependent_configs = [ ":harfbuzz-ng_config" ] 132 public_configs = [ ":harfbuzz-ng_config" ]
133 133
134 deps = [ 134 deps = [
135 "//third_party/icu:icuuc", 135 "//third_party/icu:icuuc",
136 ] 136 ]
137 137
138 cflags = [] 138 cflags = []
139 if (is_clang) { 139 if (is_clang) {
140 cflags += [ "-Wno-unused-value" ] 140 cflags += [ "-Wno-unused-value" ]
141 } 141 }
142 if (is_win) { 142 if (is_win) {
143 cflags += [ 143 cflags += [
144 "/wd4267", # size_t to 'type' converion. 144 "/wd4267", # size_t to 'type' converion.
145 "/wd4334", # Result of 32-bit shift implicitly converted to 64 bits. 145 "/wd4334", # Result of 32-bit shift implicitly converted to 64 bits.
146 ] 146 ]
147 } 147 }
148 if (is_mac) { 148 if (is_mac) {
149 sources += [ 149 sources += [
150 "src/hb-coretext.cc", 150 "src/hb-coretext.cc",
151 "src/hb-coretext.h", 151 "src/hb-coretext.h",
152 ] 152 ]
153 defines += [ "HAVE_CORETEXT" ] 153 defines += [ "HAVE_CORETEXT" ]
154 } 154 }
155 } 155 }
156 } 156 }
OLDNEW
« no previous file with comments | « third_party/freetype2/BUILD.gn ('k') | third_party/iccjpeg/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698