build/secondary/third_party/icu/BUILD.gn - Issue 595073002: Replace forward_dependent_configs with public_deps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/secondary/third_party/icu/BUILD.gn

Issue 595073002: Replace forward_dependent_configs with public_deps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/secondary/third_party/icu/BUILD.gn

diff --git a/build/secondary/third_party/icu/BUILD.gn b/build/secondary/third_party/icu/BUILD.gn

index 1a219491e8a6ba00e82a8c9e5ebdf98794bd3c56..44a6b5dc6a0aa283a894c37d11a2854d7f863c45 100644

--- a/build/secondary/third_party/icu/BUILD.gn

+++ b/build/secondary/third_party/icu/BUILD.gn

@@ -256,7 +256,7 @@ component("icui18n") {

]

configs += [ ":icu_code" ]

- direct_dependent_configs = [ ":icu_config" ]

+ public_configs = [ ":icu_config" ]

cflags = []

if (is_android || is_linux) {

@@ -470,7 +470,7 @@ component("icuuc") {

"//build/config/compiler:no_chromium_code",

]

- direct_dependent_configs = [ ":icu_config" ]

+ public_configs = [ ":icu_config" ]

if (is_win || icu_use_data_file) {

sources += [ "source/stubdata/stubdata.c" ]