Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: build/secondary/third_party/icu/BUILD.gn

Issue 595073002: Replace forward_dependent_configs with public_deps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 declare_args() { 5 declare_args() {
6 # Tells icu to load an external data file rather than rely on the icudata 6 # Tells icu to load an external data file rather than rely on the icudata
7 # being linked directly into the binary. 7 # being linked directly into the binary.
8 # 8 #
9 # This flag is a bit confusing. As of this writing, icu.gyp set the value to 9 # This flag is a bit confusing. As of this writing, icu.gyp set the value to
10 # 0 but common.gypi sets the value to 1 for most platforms (and the 1 takes 10 # 0 but common.gypi sets the value to 1 for most platforms (and the 1 takes
(...skipping 238 matching lines...) Expand 10 before | Expand all | Expand 10 after
249 configs -= [ 249 configs -= [
250 "//build/config/compiler:no_rtti", # ICU uses RTTI. 250 "//build/config/compiler:no_rtti", # ICU uses RTTI.
251 "//build/config/compiler:chromium_code", 251 "//build/config/compiler:chromium_code",
252 ] 252 ]
253 configs += [ 253 configs += [
254 "//build/config/compiler:rtti", 254 "//build/config/compiler:rtti",
255 "//build/config/compiler:no_chromium_code", 255 "//build/config/compiler:no_chromium_code",
256 ] 256 ]
257 257
258 configs += [ ":icu_code" ] 258 configs += [ ":icu_code" ]
259 direct_dependent_configs = [ ":icu_config" ] 259 public_configs = [ ":icu_config" ]
260 260
261 cflags = [] 261 cflags = []
262 if (is_android || is_linux) { 262 if (is_android || is_linux) {
263 cflags += [ 263 cflags += [
264 # ICU uses its own deprecated functions. 264 # ICU uses its own deprecated functions.
265 "-Wno-deprecated-declarations", 265 "-Wno-deprecated-declarations",
266 ] 266 ]
267 } 267 }
268 if (is_clang) { 268 if (is_clang) {
269 # uspoof.h has a U_NAMESPACE_USE macro. That's a bug, 269 # uspoof.h has a U_NAMESPACE_USE macro. That's a bug,
(...skipping 193 matching lines...) Expand 10 before | Expand all | Expand 10 after
463 463
464 configs -= [ 464 configs -= [
465 "//build/config/compiler:no_rtti", # ICU uses RTTI. 465 "//build/config/compiler:no_rtti", # ICU uses RTTI.
466 "//build/config/compiler:chromium_code", 466 "//build/config/compiler:chromium_code",
467 ] 467 ]
468 configs += [ 468 configs += [
469 "//build/config/compiler:rtti", 469 "//build/config/compiler:rtti",
470 "//build/config/compiler:no_chromium_code", 470 "//build/config/compiler:no_chromium_code",
471 ] 471 ]
472 472
473 direct_dependent_configs = [ ":icu_config" ] 473 public_configs = [ ":icu_config" ]
474 474
475 if (is_win || icu_use_data_file) { 475 if (is_win || icu_use_data_file) {
476 sources += [ "source/stubdata/stubdata.c" ] 476 sources += [ "source/stubdata/stubdata.c" ]
477 } 477 }
478 } 478 }
479 479
480 # TODO(GYP) support use_system_icu. 480 # TODO(GYP) support use_system_icu.
481 if (icu_use_data_file) { 481 if (icu_use_data_file) {
482 if (is_ios) { 482 if (is_ios) {
483 # TODO(GYP): Support mac resource bundle shown below. 483 # TODO(GYP): Support mac resource bundle shown below.
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
516 sources = [ "mac/icudtl_dat.S" ] 516 sources = [ "mac/icudtl_dat.S" ]
517 } else if (is_android) { 517 } else if (is_android) {
518 sources = [ "android/icudtl_dat.S" ] 518 sources = [ "android/icudtl_dat.S" ]
519 } else { 519 } else {
520 assert(false, "No icu data for this platform") 520 assert(false, "No icu data for this platform")
521 } 521 }
522 defines = [ "U_HIDE_DATA_SYMBOL" ] 522 defines = [ "U_HIDE_DATA_SYMBOL" ]
523 } 523 }
524 } 524 }
525 } 525 }
OLDNEW
« no previous file with comments | « build/secondary/third_party/google_toolbox_for_mac/BUILD.gn ('k') | build/secondary/third_party/leveldatabase/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698