Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 551253004: Changes to remove program effects builder (Closed)

Created:
6 years, 3 months ago by joshua.litt
Modified:
6 years, 3 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Changes to remove program effects builder BUG=skia: Committed: https://skia.googlesource.com/skia/+/23e280d1f227d94f6b3dfd0b47359cca1569e1b4

Patch Set 1 #

Patch Set 2 : small cleanups #

Patch Set 3 : small cleanups #

Patch Set 4 : removing program effects builder #

Total comments: 4

Patch Set 5 : feedback inc #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+640 lines, -851 lines) Patch
M include/gpu/GrEffectStage.h View 2 chunks +18 lines, -0 lines 0 comments Download
M include/gpu/GrShaderVar.h View 1 2 3 4 1 chunk +10 lines, -0 lines 0 comments Download
M src/core/SkXfermode.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkArithmeticMode.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/gradients/SkTwoPointRadialGradient.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrYUVtoRGBEffect.cpp View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLEffect.h View 1 2 3 4 1 chunk +34 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLProgramDesc.cpp View 1 2 3 4 2 chunks +128 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLProgramEffects.h View 1 2 3 6 chunks +38 lines, -213 lines 0 comments Download
M src/gpu/gl/GrGLProgramEffects.cpp View 1 2 3 7 chunks +10 lines, -398 lines 0 comments Download
M src/gpu/gl/builders/GrGLFragmentOnlyProgramBuilder.h View 1 2 3 1 chunk +32 lines, -14 lines 0 comments Download
M src/gpu/gl/builders/GrGLFragmentOnlyProgramBuilder.cpp View 1 2 3 1 chunk +75 lines, -6 lines 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/gl/builders/GrGLFullProgramBuilder.h View 1 2 3 2 chunks +32 lines, -24 lines 0 comments Download
M src/gpu/gl/builders/GrGLFullProgramBuilder.cpp View 1 2 3 3 chunks +136 lines, -64 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 1 2 3 3 chunks +45 lines, -43 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 2 3 3 chunks +51 lines, -51 lines 0 comments Download
M src/gpu/gl/builders/GrGLShaderBuilder.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/gl/builders/GrGLShaderBuilder.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp View 1 2 3 7 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
joshua.litt
I removed the program effects builders, and broke up GrProgramBuilder.h into GrGLFullProgramBuilder / Frag Only. ...
6 years, 3 months ago (2014-09-16 18:18:44 UTC) #2
joshua.litt
Patch has been cleaned up and rebased
6 years, 3 months ago (2014-09-18 17:49:48 UTC) #3
bsalomon
lgtm https://codereview.chromium.org/551253004/diff/60001/src/gpu/gl/GrGLEffect.h File src/gpu/gl/GrGLEffect.h (right): https://codereview.chromium.org/551253004/diff/60001/src/gpu/gl/GrGLEffect.h#newcode43 src/gpu/gl/GrGLEffect.h:43: class TransformedCoords { Curious whether this should be ...
6 years, 3 months ago (2014-09-18 18:08:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/551253004/100001
6 years, 3 months ago (2014-09-18 19:15:04 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 19:26:42 UTC) #7
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as 23e280d1f227d94f6b3dfd0b47359cca1569e1b4

Powered by Google App Engine
This is Rietveld 408576698