Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 433763002: Rename Start/StopTest to WillRunPage/DidRunPage. (Closed)

Created:
6 years, 4 months ago by chrishenry
Modified:
6 years, 4 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Rename Start/StopTest to WillRunPage/DidRunPage. Also delete buildbot_page_measurement_results, which is unused (somehow left out from previous patch). BUG=383639 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286885

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Also delete buildbot_page_measurement_results. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -716 lines) Patch
M tools/perf/measurements/page_cycler_unittest.py View 3 chunks +6 lines, -6 lines 0 comments Download
M tools/perf/metrics/test_page_measurement_results.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/page_runner.py View 3 chunks +6 lines, -6 lines 0 comments Download
M tools/telemetry/telemetry/results/buildbot_output_formatter_unittest.py View 1 12 chunks +60 lines, -60 lines 0 comments Download
D tools/telemetry/telemetry/results/buildbot_page_measurement_results.py View 1 2 1 chunk +0 lines, -114 lines 0 comments Download
M tools/telemetry/telemetry/results/buildbot_page_measurement_results_unittest.py View 1 2 1 chunk +0 lines, -446 lines 0 comments Download
M tools/telemetry/telemetry/results/csv_output_formatter_unittest.py View 4 chunks +16 lines, -16 lines 0 comments Download
M tools/telemetry/telemetry/results/gtest_test_results.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/results/gtest_test_results_unittest.py View 5 chunks +9 lines, -9 lines 0 comments Download
M tools/telemetry/telemetry/results/html_output_formatter_unittest.py View 1 3 chunks +12 lines, -12 lines 0 comments Download
M tools/telemetry/telemetry/results/json_output_formatter_unittest.py View 2 chunks +8 lines, -8 lines 0 comments Download
M tools/telemetry/telemetry/results/page_measurement_results_unittest.py View 7 chunks +30 lines, -30 lines 0 comments Download
M tools/telemetry/telemetry/results/page_test_results.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/fast_metric_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
chrishenry
6 years, 4 months ago (2014-07-31 06:21:56 UTC) #1
nednguyen
lgtm
6 years, 4 months ago (2014-07-31 19:19:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishenry@google.com/433763002/40001
6 years, 4 months ago (2014-07-31 19:20:00 UTC) #3
commit-bot: I haz the power
6 years, 4 months ago (2014-07-31 20:33:52 UTC) #4
Message was sent while issue was closed.
Change committed as 286885

Powered by Google App Engine
This is Rietveld 408576698