Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: tools/telemetry/telemetry/results/gtest_test_results_unittest.py

Issue 433763002: Rename Start/StopTest to WillRunPage/DidRunPage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Also delete buildbot_page_measurement_results. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/results/gtest_test_results_unittest.py
diff --git a/tools/telemetry/telemetry/results/gtest_test_results_unittest.py b/tools/telemetry/telemetry/results/gtest_test_results_unittest.py
index 39731e70fda5d00f39595237e429855e1e287c2b..565ddc1947c76ae63a8ffb39a8b3f28f9859e353 100644
--- a/tools/telemetry/telemetry/results/gtest_test_results_unittest.py
+++ b/tools/telemetry/telemetry/results/gtest_test_results_unittest.py
@@ -43,7 +43,7 @@ class GTestTestResultsTest(
test_page_set = _MakePageSet()
results = SummaryGtestTestResults()
- results.StartTest(test_page_set.pages[0])
+ results.WillRunPage(test_page_set.pages[0])
self._mock_timer.SetTime(0.007)
results.AddSuccess(test_page_set.pages[0])
@@ -57,7 +57,7 @@ class GTestTestResultsTest(
test_page_set = _MakePageSet()
results = SummaryGtestTestResults()
- results.StartTest(test_page_set.pages[0])
+ results.WillRunPage(test_page_set.pages[0])
exc_info = self.CreateException()
results.AddValue(failure.FailureValue(test_page_set.pages[0], exc_info))
results.PrintSummary()
@@ -74,7 +74,7 @@ class GTestTestResultsTest(
def testSingleSkippedPage(self):
test_page_set = _MakePageSet()
results = SummaryGtestTestResults()
- results.StartTest(test_page_set.pages[0])
+ results.WillRunPage(test_page_set.pages[0])
self._mock_timer.SetTime(0.007)
results.AddValue(skip.SkipValue(test_page_set.pages[0],
'Page skipped for testing reason'))
@@ -89,19 +89,19 @@ class GTestTestResultsTest(
results = SummaryGtestTestResults()
exc_info = self.CreateException()
- results.StartTest(test_page_set.pages[0])
+ results.WillRunPage(test_page_set.pages[0])
self._mock_timer.SetTime(0.007)
results.AddSuccess(test_page_set.pages[0])
- results.StartTest(test_page_set.pages[1])
+ results.WillRunPage(test_page_set.pages[1])
self._mock_timer.SetTime(0.009)
results.AddValue(failure.FailureValue(test_page_set.pages[1], exc_info))
- results.StartTest(test_page_set.pages[2])
+ results.WillRunPage(test_page_set.pages[2])
self._mock_timer.SetTime(0.015)
results.AddValue(failure.FailureValue(test_page_set.pages[2], exc_info))
- results.StartTest(test_page_set.pages[3])
+ results.WillRunPage(test_page_set.pages[3])
self._mock_timer.SetTime(0.020)
results.AddSuccess(test_page_set.pages[3])
@@ -129,14 +129,14 @@ class GTestTestResultsTest(
results = SummaryGtestTestResults()
exc_info = self.CreateException()
- results.StartTest(test_page_set.pages[0])
+ results.WillRunPage(test_page_set.pages[0])
self._mock_timer.SetTime(0.007)
results.AddSuccess(test_page_set.pages[0])
expected = ('[ RUN ] http://www.foo.com/\n'
'[ OK ] http://www.foo.com/ (7 ms)\n')
self.assertEquals(expected, ''.join(results.output_data))
- results.StartTest(test_page_set.pages[1])
+ results.WillRunPage(test_page_set.pages[1])
self._mock_timer.SetTime(0.009)
exception_trace = ''.join(traceback.format_exception(*exc_info))
results.AddValue(failure.FailureValue(test_page_set.pages[1], exc_info))

Powered by Google App Engine
This is Rietveld 408576698