tools/telemetry/telemetry/results/json_output_formatter_unittest.py - Issue 433763002: Rename Start/StopTest to WillRunPage/DidRunPage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/results/json_output_formatter_unittest.py

Issue 433763002: Rename Start/StopTest to WillRunPage/DidRunPage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Also delete buildbot_page_measurement_results. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/results/html_output_formatter_unittest.py ('k') | tools/telemetry/telemetry/results/page_measurement_results_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/results/json_output_formatter_unittest.py

diff --git a/tools/telemetry/telemetry/results/json_output_formatter_unittest.py b/tools/telemetry/telemetry/results/json_output_formatter_unittest.py

index eaa552b782c6a0bd33cd5026ce8e965e374bf822..7b59c17cd1423b94560f179828d72830625c0472 100644

--- a/tools/telemetry/telemetry/results/json_output_formatter_unittest.py

+++ b/tools/telemetry/telemetry/results/json_output_formatter_unittest.py

@@ -37,20 +37,20 @@ class JsonOutputFormatterTest(unittest.TestCase):

self._output.truncate(0)

- results.StartTest(self._page_set[0])

+ results.WillRunPage(self._page_set[0])

v0 = scalar.ScalarValue(results.current_page, 'foo', 'seconds', 3)

results.AddValue(v0)

- results.StopTest(self._page_set[0])

+ results.DidRunPage(self._page_set[0])

self._formatter.Format(results)

json.loads(self._output.getvalue())

def testAsDictWithOnePage(self):

results = page_test_results.PageTestResults()

- results.StartTest(self._page_set[0])

+ results.WillRunPage(self._page_set[0])

v0 = scalar.ScalarValue(results.current_page, 'foo', 'seconds', 3)

results.AddValue(v0)

- results.StopTest(self._page_set[0])

+ results.DidRunPage(self._page_set[0])

d = ResultsAsDict(results)

@@ -59,15 +59,15 @@ class JsonOutputFormatterTest(unittest.TestCase):

def testAsDictWithTwoPages(self):

results = page_test_results.PageTestResults()

- results.StartTest(self._page_set[0])

+ results.WillRunPage(self._page_set[0])

v0 = scalar.ScalarValue(results.current_page, 'foo', 'seconds', 3)

results.AddValue(v0)

- results.StopTest(self._page_set[0])

+ results.DidRunPage(self._page_set[0])

- results.StartTest(self._page_set[1])

+ results.WillRunPage(self._page_set[1])

v1 = scalar.ScalarValue(results.current_page, 'bar', 'seconds', 4)

results.AddValue(v1)

- results.StopTest(self._page_set[1])

+ results.DidRunPage(self._page_set[1])

d = ResultsAsDict(results)