Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: tools/perf/measurements/page_cycler_unittest.py

Issue 433763002: Rename Start/StopTest to WillRunPage/DidRunPage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Also delete buildbot_page_measurement_results. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/perf/metrics/test_page_measurement_results.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/measurements/page_cycler_unittest.py
diff --git a/tools/perf/measurements/page_cycler_unittest.py b/tools/perf/measurements/page_cycler_unittest.py
index 0fd3169ab56c0d28cfc7b94fb06f75a58f4a961e..6564990010ee6f9fecd02bf9e9cad65b59b3c576 100644
--- a/tools/perf/measurements/page_cycler_unittest.py
+++ b/tools/perf/measurements/page_cycler_unittest.py
@@ -143,13 +143,13 @@ class PageCyclerUnitTest(unittest.TestCase):
for i in range(5):
results = page_measurement_results.PageMeasurementResults()
- results.StartTest(page)
+ results.WillRunPage(page)
cycler.WillNavigateToPage(page, tab)
self.assertEqual(max(0, i - 2), tab.clear_cache_calls,
'Iteration %d tab.clear_cache_calls %d' %
(i, tab.clear_cache_calls))
cycler.MeasurePage(page, tab, results)
- results.StopTest(page)
+ results.DidRunPage(page)
values = results.all_page_specific_values
self.assertGreater(len(values), 2)
@@ -168,10 +168,10 @@ class PageCyclerUnitTest(unittest.TestCase):
for i in range(3):
for page in pages:
results = page_measurement_results.PageMeasurementResults()
- results.StartTest(page)
+ results.WillRunPage(page)
cycler.WillNavigateToPage(page, tab)
cycler.MeasurePage(page, tab, results)
- results.StopTest(page)
+ results.DidRunPage(page)
values = results.all_page_specific_values
self.assertGreater(len(values), 2)
@@ -193,10 +193,10 @@ class PageCyclerUnitTest(unittest.TestCase):
for i in range(2):
for page in pages:
results = page_measurement_results.PageMeasurementResults()
- results.StartTest(page)
+ results.WillRunPage(page)
cycler.WillNavigateToPage(page, tab)
cycler.MeasurePage(page, tab, results)
- results.StopTest(page)
+ results.DidRunPage(page)
values = results.all_page_specific_values
self.assertEqual(4, len(values))
« no previous file with comments | « no previous file | tools/perf/metrics/test_page_measurement_results.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698