tools/telemetry/telemetry/web_perf/metrics/fast_metric_unittest.py - Issue 433763002: Rename Start/StopTest to WillRunPage/DidRunPage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/web_perf/metrics/fast_metric_unittest.py

Issue 433763002: Rename Start/StopTest to WillRunPage/DidRunPage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Also delete buildbot_page_measurement_results. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/web_perf/metrics/fast_metric_unittest.py

diff --git a/tools/telemetry/telemetry/web_perf/metrics/fast_metric_unittest.py b/tools/telemetry/telemetry/web_perf/metrics/fast_metric_unittest.py

index edb64bc1ba02906558e8308b6f26ac6ed3d9fcb3..229c2f5780133c310681e6cd8623907d9b5b6e09 100644

--- a/tools/telemetry/telemetry/web_perf/metrics/fast_metric_unittest.py

+++ b/tools/telemetry/telemetry/web_perf/metrics/fast_metric_unittest.py

@@ -42,10 +42,10 @@ class RendererThreadHelper(object):

for s in self._async_slices]

results = page_measurement_results.PageMeasurementResults()

fake_page = None

- results.StartTest(fake_page)

+ results.WillRunPage(fake_page)

metric.AddResults(self._model, self._renderer_thread, interaction_records,

results)

- results.StopTest(fake_page)

+ results.DidRunPage(fake_page)

return results