Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: tools/telemetry/telemetry/results/csv_output_formatter_unittest.py

Issue 433763002: Rename Start/StopTest to WillRunPage/DidRunPage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Also delete buildbot_page_measurement_results. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/results/csv_output_formatter_unittest.py
diff --git a/tools/telemetry/telemetry/results/csv_output_formatter_unittest.py b/tools/telemetry/telemetry/results/csv_output_formatter_unittest.py
index aad3ae0a4bedb0d844199169a923b7c15115f302..e1f8e4455bba885df356b23111c356af11d09281 100644
--- a/tools/telemetry/telemetry/results/csv_output_formatter_unittest.py
+++ b/tools/telemetry/telemetry/results/csv_output_formatter_unittest.py
@@ -43,12 +43,12 @@ class CsvOutputFormatterTest(unittest.TestCase):
def test_with_no_results_on_second_run(self):
results = page_test_results.PageTestResults()
- results.StartTest(self._page_set[0])
+ results.WillRunPage(self._page_set[0])
results.AddValue(scalar.ScalarValue(self._page_set[0], 'foo', 'seconds', 3))
- results.StopTest(self._page_set[0])
+ results.DidRunPage(self._page_set[0])
- results.StartTest(self._page_set[1])
- results.StopTest(self._page_set[1])
+ results.WillRunPage(self._page_set[1])
+ results.DidRunPage(self._page_set[1])
self._formatter.Format(results)
@@ -60,14 +60,14 @@ class CsvOutputFormatterTest(unittest.TestCase):
def test_fewer_results_on_second_run(self):
results = page_test_results.PageTestResults()
- results.StartTest(self._page_set[0])
+ results.WillRunPage(self._page_set[0])
results.AddValue(scalar.ScalarValue(self._page_set[0], 'foo', 'seconds', 3))
results.AddValue(scalar.ScalarValue(self._page_set[0], 'bar', 'seconds', 4))
- results.StopTest(self._page_set[0])
+ results.DidRunPage(self._page_set[0])
- results.StartTest(self._page_set[1])
+ results.WillRunPage(self._page_set[1])
results.AddValue(scalar.ScalarValue(self._page_set[1], 'bar', 'seconds', 5))
- results.StopTest(self._page_set[1])
+ results.DidRunPage(self._page_set[1])
self._formatter.Format(results)
self.assertEqual(['page_name', 'bar (seconds)', 'foo (seconds)'],
@@ -78,13 +78,13 @@ class CsvOutputFormatterTest(unittest.TestCase):
def test_with_output_at_print_summary_time(self):
results = page_test_results.PageTestResults()
- results.StartTest(self._page_set[0])
+ results.WillRunPage(self._page_set[0])
results.AddValue(scalar.ScalarValue(self._page_set[0], 'foo', 'seconds', 3))
- results.StopTest(self._page_set[0])
+ results.DidRunPage(self._page_set[0])
- results.StartTest(self._page_set[1])
+ results.WillRunPage(self._page_set[1])
results.AddValue(scalar.ScalarValue(self._page_set[1], 'bar', 'seconds', 4))
- results.StopTest(self._page_set[1])
+ results.DidRunPage(self._page_set[1])
self._formatter.Format(results)
@@ -98,17 +98,17 @@ class CsvOutputFormatterTest(unittest.TestCase):
def test_histogram(self):
results = page_test_results.PageTestResults()
- results.StartTest(self._page_set[0])
+ results.WillRunPage(self._page_set[0])
results.AddValue(histogram.HistogramValue(
self._page_set[0], 'a', '',
raw_value_json='{"buckets": [{"low": 1, "high": 2, "count": 1}]}'))
- results.StopTest(self._page_set[0])
+ results.DidRunPage(self._page_set[0])
- results.StartTest(self._page_set[1])
+ results.WillRunPage(self._page_set[1])
results.AddValue(histogram.HistogramValue(
self._page_set[1], 'a', '',
raw_value_json='{"buckets": [{"low": 2, "high": 3, "count": 1}]}'))
- results.StopTest(self._page_set[1])
+ results.DidRunPage(self._page_set[1])
self._formatter.Format(results)

Powered by Google App Engine
This is Rietveld 408576698