Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Unified Diff: tools/telemetry/telemetry/page/page_runner.py

Issue 433763002: Rename Start/StopTest to WillRunPage/DidRunPage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Also delete buildbot_page_measurement_results. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/page_runner.py
diff --git a/tools/telemetry/telemetry/page/page_runner.py b/tools/telemetry/telemetry/page/page_runner.py
index d5f0c94b1998a2c46f75a8badb0a14dbebec5099..358e50479321e45bdf80f9952e329f864c1d2249 100644
--- a/tools/telemetry/telemetry/page/page_runner.py
+++ b/tools/telemetry/telemetry/page/page_runner.py
@@ -390,10 +390,10 @@ def Run(test, page_set, expectations, finder_options):
for page in list(pages):
if not test.CanRunForPage(page):
- results.StartTest(page)
+ results.WillRunPage(page)
logging.debug('Skipping test: it cannot run for %s', page.url)
results.AddValue(skip.SkipValue(page, 'Test cannot run'))
- results.StopTest(page)
+ results.DidRunPage(page)
pages.remove(page)
if not pages:
@@ -413,14 +413,14 @@ def Run(test, page_set, expectations, finder_options):
state.repeat_state.WillRunPage()
test.WillRunPageRepeats(page)
while state.repeat_state.ShouldRepeatPage():
- results.StartTest(page)
+ results.WillRunPage(page)
try:
results = _PrepareAndRunPage(
test, page_set, expectations, finder_options, browser_options,
page, credentials_path, possible_browser, results, state)
finally:
state.repeat_state.DidRunPage()
- results.StopTest(page)
+ results.DidRunPage(page)
test.DidRunPageRepeats(page)
if (not test.max_failures is None and
len(results.failures) > test.max_failures):
@@ -498,10 +498,10 @@ def _CheckArchives(page_set, pages, results):
'against live sites, pass the flag --use-live-sites.')
for page in pages_missing_archive_path + pages_missing_archive_data:
- results.StartTest(page)
+ results.WillRunPage(page)
results.AddValue(failure.FailureValue.FromMessage(
page, 'Page set archive doesn\'t exist.'))
- results.StopTest(page)
+ results.DidRunPage(page)
return [page for page in pages if page not in
pages_missing_archive_path + pages_missing_archive_data]

Powered by Google App Engine
This is Rietveld 408576698