Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: tools/telemetry/telemetry/results/html_output_formatter_unittest.py

Issue 433763002: Rename Start/StopTest to WillRunPage/DidRunPage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Also delete buildbot_page_measurement_results. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/results/html_output_formatter_unittest.py
diff --git a/tools/telemetry/telemetry/results/html_output_formatter_unittest.py b/tools/telemetry/telemetry/results/html_output_formatter_unittest.py
index 6a321eff5b24b371d8a7f8e8d05ea51bad289a8a..8b4b0a0cc7e13be73418e6948ccd57551eff77cb 100644
--- a/tools/telemetry/telemetry/results/html_output_formatter_unittest.py
+++ b/tools/telemetry/telemetry/results/html_output_formatter_unittest.py
@@ -41,17 +41,17 @@ class HtmlOutputFormatterTest(unittest.TestCase):
# Run the first time and verify the results are written to the HTML file.
results = page_test_results.PageTestResults()
- results.StartTest(test_page_set.pages[0])
+ results.WillRunPage(test_page_set.pages[0])
results.AddValue(scalar.ScalarValue(
test_page_set.pages[0], 'a', 'seconds', 3))
results.AddSuccess(test_page_set.pages[0])
- results.StopTest(test_page_set.pages[0])
+ results.DidRunPage(test_page_set.pages[0])
- results.StartTest(test_page_set.pages[1])
+ results.WillRunPage(test_page_set.pages[1])
results.AddValue(scalar.ScalarValue(
test_page_set.pages[1], 'a', 'seconds', 7))
results.AddSuccess(test_page_set.pages[1])
- results.StopTest(test_page_set.pages[1])
+ results.DidRunPage(test_page_set.pages[1])
formatter = DeterministicHtmlOutputFormatter(
output_file, 'test_name', False, False, 'browser_type')
@@ -98,17 +98,17 @@ class HtmlOutputFormatterTest(unittest.TestCase):
# Run the second time and verify the results are appended to the HTML file.
output_file.seek(0)
results = page_test_results.PageTestResults()
- results.StartTest(test_page_set.pages[0])
+ results.WillRunPage(test_page_set.pages[0])
results.AddValue(scalar.ScalarValue(
test_page_set.pages[0], 'a', 'seconds', 4))
results.AddSuccess(test_page_set.pages[0])
- results.StopTest(test_page_set.pages[0])
+ results.DidRunPage(test_page_set.pages[0])
- results.StartTest(test_page_set.pages[1])
+ results.WillRunPage(test_page_set.pages[1])
results.AddValue(scalar.ScalarValue(
test_page_set.pages[1], 'a', 'seconds', 8))
results.AddSuccess(test_page_set.pages[1])
- results.StopTest(test_page_set.pages[1])
+ results.DidRunPage(test_page_set.pages[1])
formatter = DeterministicHtmlOutputFormatter(
output_file, 'test_name', False, False, 'browser_type')
@@ -194,17 +194,17 @@ class HtmlOutputFormatterTest(unittest.TestCase):
# Now reset the results and verify the old ones are gone.
output_file.seek(0)
results = page_test_results.PageTestResults()
- results.StartTest(test_page_set.pages[0])
+ results.WillRunPage(test_page_set.pages[0])
results.AddValue(scalar.ScalarValue(
test_page_set.pages[0], 'a', 'seconds', 5))
results.AddSuccess(test_page_set.pages[0])
- results.StopTest(test_page_set.pages[0])
+ results.DidRunPage(test_page_set.pages[0])
- results.StartTest(test_page_set.pages[1])
+ results.WillRunPage(test_page_set.pages[1])
results.AddValue(scalar.ScalarValue(
test_page_set.pages[1], 'a', 'seconds', 9))
results.AddSuccess(test_page_set.pages[1])
- results.StopTest(test_page_set.pages[1])
+ results.DidRunPage(test_page_set.pages[1])
formatter = DeterministicHtmlOutputFormatter(
output_file, 'test_name', True, False, 'browser_type')

Powered by Google App Engine
This is Rietveld 408576698