tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py - Issue 433763002: Rename Start/StopTest to WillRunPage/DidRunPage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py

Issue 433763002: Rename Start/StopTest to WillRunPage/DidRunPage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Also delete buildbot_page_measurement_results. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py

diff --git a/tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py b/tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py

index 6ac8f77278350b39efb2ce8da5fa1eefd8eaacd4..71a179c00acc67254e5355cae7c473049d4fd131 100644

--- a/tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py

+++ b/tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py

@@ -92,11 +92,11 @@ class TimelineBasedMetricTestData(object):

self._model, self._renderer_thread, GetMetricFromMetricType)

self._ps = page_set.PageSet(file_path=os.path.dirname(__file__))

self._ps.AddPageWithDefaultRunNavigate('http://www.bar.com/')

- self._results.StartTest(self._ps.pages[0])

+ self._results.WillRunPage(self._ps.pages[0])

def AddResults(self):

self._metric.AddResults(self._results)

- self._results.StopTest(self._ps.pages[0])

+ self._results.DidRunPage(self._ps.pages[0])

class TimelineBasedMetricsTests(unittest.TestCase):

« no previous file with comments | « tools/telemetry/telemetry/web_perf/metrics/fast_metric_unittest.py ('k') | no next file » | no next file with comments »