Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Issue 393713005: Revert 284459 "Add FailureValue and wire it through PageTestResu..." (Closed)

Created:
6 years, 5 months ago by sky
Modified:
6 years, 5 months ago
Reviewers:
chrishenry
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 284459 "Add FailureValue and wire it through PageTestResu..." Reverting in hopes of getting android telemetry_perf_unittests to green. Here's output: http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/14733/steps/telemetry_perf_unittests/logs/stdio Unhandled exception while running file://scrollable_page.html Traceback (most recent call last): _RunPage at tools/telemetry/telemetry/page/page_runner.py:533 test.RunPage(page, page_state.tab, results) RunPage at tools/telemetry/telemetry/page/page_test.py:228 self.WillRunActions(page, tab) WillRunActions at tools/perf/measurements/smoothness.py:26 self._power_metric.Start(page, tab) Start at tools/perf/metrics/power.py:77 self._browser.platform.StartMonitoringPower(self._browser) StartMonitoringPower at tools/telemetry/telemetry/core/platform/__init__.py:193 self._platform_backend.StartMonitoringPower(browser) StartMonitoringPower at tools/telemetry/telemetry/core/platform/android_platform_backend.py:251 self._powermonitor.StartMonitoringPower(browser) StartMonitoringPower at tools/telemetry/telemetry/core/platform/power_monitor/android_temperature_monitor.py:31 self._power_monitor.StartMonitoringPower(browser) StartMonitoringPower at tools/telemetry/telemetry/core/platform/power_monitor/power_monitor_controller.py:29 self._active_monitor.StartMonitoringPower(browser) StartMonitoringPower at tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor.py:33 'Must call StopMonitoringPower().') AssertionError: Must call StopMonitoringPower(). > Add FailureValue and wire it through PageTestResults. > > BUG=392901 > > Review URL: https://codereview.chromium.org/399263003 TBR=chrishenry@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284497

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -225 lines) Patch
M trunk/src/tools/perf/measurements/skpicture_printer_unittest.py View 2 chunks +1 line, -3 lines 0 comments Download
M trunk/src/tools/telemetry/telemetry/page/page_runner.py View 5 chunks +5 lines, -6 lines 0 comments Download
M trunk/src/tools/telemetry/telemetry/page/profile_generator.py View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/tools/telemetry/telemetry/page/record_wpr.py View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/tools/telemetry/telemetry/results/block_page_measurement_results.py View 1 chunk +4 lines, -5 lines 0 comments Download
M trunk/src/tools/telemetry/telemetry/results/buildbot_page_measurement_results.py View 2 chunks +1 line, -6 lines 0 comments Download
M trunk/src/tools/telemetry/telemetry/results/buildbot_page_measurement_results_unittest.py View 3 chunks +4 lines, -7 lines 0 comments Download
M trunk/src/tools/telemetry/telemetry/results/gtest_test_results.py View 3 chunks +13 lines, -13 lines 0 comments Download
M trunk/src/tools/telemetry/telemetry/results/gtest_test_results_unittest.py View 6 chunks +10 lines, -11 lines 0 comments Download
M trunk/src/tools/telemetry/telemetry/results/page_measurement_results.py View 2 chunks +1 line, -3 lines 0 comments Download
M trunk/src/tools/telemetry/telemetry/results/page_measurement_results_unittest.py View 4 chunks +6 lines, -8 lines 0 comments Download
M trunk/src/tools/telemetry/telemetry/results/page_test_results.py View 4 chunks +18 lines, -17 lines 0 comments Download
M trunk/src/tools/telemetry/telemetry/results/page_test_results_unittest.py View 2 chunks +3 lines, -4 lines 0 comments Download
D trunk/src/tools/telemetry/telemetry/value/failure.py View 1 chunk +0 lines, -83 lines 0 comments Download
D trunk/src/tools/telemetry/telemetry/value/failure_unittest.py View 1 chunk +0 lines, -44 lines 0 comments Download
M trunk/src/tools/telemetry/telemetry/value/merge_values.py View 2 chunks +0 lines, -9 lines 0 comments Download
M trunk/src/tools/telemetry/telemetry/value/summary.py View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sky
6 years, 5 months ago (2014-07-21 20:52:26 UTC) #1
sky
6 years, 5 months ago (2014-07-21 20:52:38 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r284497 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698