Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1097)

Unified Diff: trunk/src/tools/telemetry/telemetry/value/summary.py

Issue 393713005: Revert 284459 "Add FailureValue and wire it through PageTestResu..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/tools/telemetry/telemetry/value/merge_values.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/tools/telemetry/telemetry/value/summary.py
===================================================================
--- trunk/src/tools/telemetry/telemetry/value/summary.py (revision 284496)
+++ trunk/src/tools/telemetry/telemetry/value/summary.py (working copy)
@@ -4,7 +4,6 @@
from collections import defaultdict
-from telemetry.value import failure
from telemetry.value import merge_values
class Summary(object):
@@ -59,9 +58,7 @@
return self._interleaved_computed_per_page_values_and_summaries
def _ComputePerPageValues(self, all_page_specific_values):
- all_successful_page_values = [
- v for v in all_page_specific_values if not isinstance(
- v, failure.FailureValue)]
+ all_successful_page_values = all_page_specific_values
# We will later need to determine how many values were originally created
# for each value name, to apply a workaround meant to clean up the printf
« no previous file with comments | « trunk/src/tools/telemetry/telemetry/value/merge_values.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698