Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Unified Diff: trunk/src/tools/telemetry/telemetry/results/buildbot_page_measurement_results.py

Issue 393713005: Revert 284459 "Add FailureValue and wire it through PageTestResu..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/tools/telemetry/telemetry/results/buildbot_page_measurement_results.py
===================================================================
--- trunk/src/tools/telemetry/telemetry/results/buildbot_page_measurement_results.py (revision 284496)
+++ trunk/src/tools/telemetry/telemetry/results/buildbot_page_measurement_results.py (working copy)
@@ -52,9 +52,6 @@
buildbot_value = value.GetBuildbotValue()
buildbot_data_type = value.GetBuildbotDataType(
output_context=value_module.PER_PAGE_RESULT_OUTPUT_CONTEXT)
- if buildbot_value is None or buildbot_data_type is None:
- return
-
buildbot_measurement_name, buildbot_trace_name = (
value.GetBuildbotMeasurementAndTraceNameForPerPageResult())
self._PrintPerfResult(buildbot_measurement_name,
@@ -71,12 +68,10 @@
buildbot_value = value.GetBuildbotValue()
buildbot_data_type = value.GetBuildbotDataType(
output_context=value_module.COMPUTED_PER_PAGE_SUMMARY_OUTPUT_CONTEXT)
- if buildbot_value is None or buildbot_data_type is None:
- return
-
buildbot_measurement_name, buildbot_trace_name = (
value.GetBuildbotMeasurementAndTraceNameForComputedSummaryResult(
self._trace_tag))
+
self._PrintPerfResult(buildbot_measurement_name,
buildbot_trace_name,
buildbot_value, value.units, buildbot_data_type)

Powered by Google App Engine
This is Rietveld 408576698