trunk/src/tools/telemetry/telemetry/results/page_test_results_unittest.py - Issue 393713005: Revert 284459 "Add FailureValue and wire it through PageTestResu..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: trunk/src/tools/telemetry/telemetry/results/page_test_results_unittest.py

Issue 393713005: Revert 284459 "Add FailureValue and wire it through PageTestResu..." (Closed) Base URL: svn://svn.chromium.org/chrome/

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: trunk/src/tools/telemetry/telemetry/results/page_test_results_unittest.py

===================================================================

--- trunk/src/tools/telemetry/telemetry/results/page_test_results_unittest.py (revision 284496)

+++ trunk/src/tools/telemetry/telemetry/results/page_test_results_unittest.py (working copy)

@@ -6,7 +6,6 @@

from telemetry.page import page_set

from telemetry.results import page_test_results

-from telemetry.value import failure

class NonPrintingPageTestResults(

page_test_results.PageTestResults):

@@ -29,8 +28,8 @@

def test_failures(self):

results = NonPrintingPageTestResults()

- results.AddValue(

- failure.FailureValue(self.pages[0], self.CreateException()))

+ results.AddFailure(self.pages[0], self.CreateException())

results.AddSuccess(self.pages[1])

- self.assertEquals(results.pages_that_had_failures, [self.pages[0]])

+ self.assertEquals(results.pages_that_had_failures,

+ set([self.pages[0]]))

self.assertEquals(results.successes, [self.pages[1]])