trunk/src/tools/perf/measurements/skpicture_printer_unittest.py - Issue 393713005: Revert 284459 "Add FailureValue and wire it through PageTestResu..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: trunk/src/tools/perf/measurements/skpicture_printer_unittest.py

Issue 393713005: Revert 284459 "Add FailureValue and wire it through PageTestResu..." (Closed) Base URL: svn://svn.chromium.org/chrome/

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: trunk/src/tools/perf/measurements/skpicture_printer_unittest.py

===================================================================

--- trunk/src/tools/perf/measurements/skpicture_printer_unittest.py (revision 284496)

+++ trunk/src/tools/perf/measurements/skpicture_printer_unittest.py (working copy)

@@ -9,7 +9,6 @@

from telemetry.page import page_measurement_unittest_base

from telemetry.unittest import options_for_unittests

from telemetry.unittest import test

-from telemetry.value import failure

class SkpicturePrinterUnitTest(

@@ -29,8 +28,7 @@

# Picture printing is not supported on all platforms.

if results.failures:

- assert 'not supported' in failure.GetStringFromExcInfo(

- results.failures[0].exc_info)

+ assert 'not supported' in results.failures[0][1]

return

saved_picture_count = results.FindAllPageSpecificValuesNamed(

« no previous file with comments | « no previous file | trunk/src/tools/telemetry/telemetry/page/page_runner.py » ('j') | no next file with comments »