Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: trunk/src/tools/telemetry/telemetry/value/merge_values.py

Issue 393713005: Revert 284459 "Add FailureValue and wire it through PageTestResu..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/tools/telemetry/telemetry/value/merge_values.py
===================================================================
--- trunk/src/tools/telemetry/telemetry/value/merge_values.py (revision 284496)
+++ trunk/src/tools/telemetry/telemetry/value/merge_values.py (working copy)
@@ -1,9 +1,6 @@
# Copyright 2013 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-
-from telemetry.value import failure
-
def MergeLikeValuesFromSamePage(all_values):
"""Merges values that measure the same thing on the same page.
@@ -111,12 +108,6 @@
merge_groups = {}
merge_groups_in_creation_order = []
for value in all_values:
- # TODO(chrishenry): This is temporary. When we figure out the
- # right summarization strategy for page runs with failures, we
- # should use that instead.
- if isinstance(value, failure.FailureValue):
- continue
-
key = key_func(value)
if key not in merge_groups:
merge_groups[key] = []
« no previous file with comments | « trunk/src/tools/telemetry/telemetry/value/failure_unittest.py ('k') | trunk/src/tools/telemetry/telemetry/value/summary.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698