Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: trunk/src/tools/telemetry/telemetry/results/buildbot_page_measurement_results_unittest.py

Issue 393713005: Revert 284459 "Add FailureValue and wire it through PageTestResu..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/tools/telemetry/telemetry/results/buildbot_page_measurement_results_unittest.py
===================================================================
--- trunk/src/tools/telemetry/telemetry/results/buildbot_page_measurement_results_unittest.py (revision 284496)
+++ trunk/src/tools/telemetry/telemetry/results/buildbot_page_measurement_results_unittest.py (working copy)
@@ -5,12 +5,11 @@
from telemetry import perf_tests_helper
from telemetry.page import page_set
-from telemetry.results import base_test_results_unittest
-from telemetry.results import buildbot_page_measurement_results
-from telemetry.value import failure
from telemetry.value import histogram
from telemetry.value import list_of_scalar_values
from telemetry.value import scalar
+from telemetry.results import base_test_results_unittest
+from telemetry.results import buildbot_page_measurement_results
def _MakePageSet():
@@ -131,8 +130,7 @@
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[0], 'a', 'seconds', 3))
measurement_results.DidMeasurePage()
- measurement_results.AddValue(
- failure.FailureValue.FromMessage(test_page_set.pages[0], 'message'))
+ measurement_results.AddFailureMessage(test_page_set.pages[0], 'message')
measurement_results.WillMeasurePage(test_page_set.pages[1])
measurement_results.AddValue(scalar.ScalarValue(
@@ -163,8 +161,7 @@
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[1], 'a', 'seconds', 7))
measurement_results.DidMeasurePage()
- measurement_results.AddValue(
- failure.FailureValue.FromMessage(test_page_set.pages[1], 'message'))
+ measurement_results.AddFailureMessage(test_page_set.pages[1], 'message')
measurement_results.WillMeasurePage(test_page_set.pages[0])
measurement_results.AddValue(scalar.ScalarValue(

Powered by Google App Engine
This is Rietveld 408576698