Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Side by Side Diff: trunk/src/tools/telemetry/telemetry/results/page_test_results_unittest.py

Issue 393713005: Revert 284459 "Add FailureValue and wire it through PageTestResu..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 import os 4 import os
5 from telemetry.results import base_test_results_unittest 5 from telemetry.results import base_test_results_unittest
6 6
7 from telemetry.page import page_set 7 from telemetry.page import page_set
8 from telemetry.results import page_test_results 8 from telemetry.results import page_test_results
9 from telemetry.value import failure
10 9
11 class NonPrintingPageTestResults( 10 class NonPrintingPageTestResults(
12 page_test_results.PageTestResults): 11 page_test_results.PageTestResults):
13 def __init__(self): 12 def __init__(self):
14 super(NonPrintingPageTestResults, self).__init__() 13 super(NonPrintingPageTestResults, self).__init__()
15 14
16 def _PrintPerfResult(self, *args): 15 def _PrintPerfResult(self, *args):
17 pass 16 pass
18 17
19 class PageTestResultsTest(base_test_results_unittest.BaseTestResultsUnittest): 18 class PageTestResultsTest(base_test_results_unittest.BaseTestResultsUnittest):
20 def setUp(self): 19 def setUp(self):
21 self.page_set = page_set.PageSet(file_path=os.path.dirname(__file__)) 20 self.page_set = page_set.PageSet(file_path=os.path.dirname(__file__))
22 self.page_set.AddPageWithDefaultRunNavigate("http://www.bar.com/") 21 self.page_set.AddPageWithDefaultRunNavigate("http://www.bar.com/")
23 self.page_set.AddPageWithDefaultRunNavigate("http://www.baz.com/") 22 self.page_set.AddPageWithDefaultRunNavigate("http://www.baz.com/")
24 self.page_set.AddPageWithDefaultRunNavigate("http://www.foo.com/") 23 self.page_set.AddPageWithDefaultRunNavigate("http://www.foo.com/")
25 24
26 @property 25 @property
27 def pages(self): 26 def pages(self):
28 return self.page_set.pages 27 return self.page_set.pages
29 28
30 def test_failures(self): 29 def test_failures(self):
31 results = NonPrintingPageTestResults() 30 results = NonPrintingPageTestResults()
32 results.AddValue( 31 results.AddFailure(self.pages[0], self.CreateException())
33 failure.FailureValue(self.pages[0], self.CreateException()))
34 results.AddSuccess(self.pages[1]) 32 results.AddSuccess(self.pages[1])
35 self.assertEquals(results.pages_that_had_failures, [self.pages[0]]) 33 self.assertEquals(results.pages_that_had_failures,
34 set([self.pages[0]]))
36 self.assertEquals(results.successes, [self.pages[1]]) 35 self.assertEquals(results.successes, [self.pages[1]])
OLDNEW
« no previous file with comments | « trunk/src/tools/telemetry/telemetry/results/page_test_results.py ('k') | trunk/src/tools/telemetry/telemetry/value/failure.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698