Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: trunk/src/tools/perf/measurements/skpicture_printer_unittest.py

Issue 393713005: Revert 284459 "Add FailureValue and wire it through PageTestResu..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | trunk/src/tools/telemetry/telemetry/page/page_runner.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import shutil 5 import shutil
6 import tempfile 6 import tempfile
7 7
8 from measurements import skpicture_printer 8 from measurements import skpicture_printer
9 from telemetry.page import page_measurement_unittest_base 9 from telemetry.page import page_measurement_unittest_base
10 from telemetry.unittest import options_for_unittests 10 from telemetry.unittest import options_for_unittests
11 from telemetry.unittest import test 11 from telemetry.unittest import test
12 from telemetry.value import failure
13 12
14 13
15 class SkpicturePrinterUnitTest( 14 class SkpicturePrinterUnitTest(
16 page_measurement_unittest_base.PageMeasurementUnitTestBase): 15 page_measurement_unittest_base.PageMeasurementUnitTestBase):
17 def setUp(self): 16 def setUp(self):
18 self._options = options_for_unittests.GetCopy() 17 self._options = options_for_unittests.GetCopy()
19 self._options.skp_outdir = tempfile.mkdtemp('_skp_test') 18 self._options.skp_outdir = tempfile.mkdtemp('_skp_test')
20 19
21 def tearDown(self): 20 def tearDown(self):
22 shutil.rmtree(self._options.skp_outdir) 21 shutil.rmtree(self._options.skp_outdir)
23 22
24 @test.Disabled('android') 23 @test.Disabled('android')
25 def testSkpicturePrinter(self): 24 def testSkpicturePrinter(self):
26 ps = self.CreatePageSetFromFileInUnittestDataDir('blank.html') 25 ps = self.CreatePageSetFromFileInUnittestDataDir('blank.html')
27 measurement = skpicture_printer.SkpicturePrinter() 26 measurement = skpicture_printer.SkpicturePrinter()
28 results = self.RunMeasurement(measurement, ps, options=self._options) 27 results = self.RunMeasurement(measurement, ps, options=self._options)
29 28
30 # Picture printing is not supported on all platforms. 29 # Picture printing is not supported on all platforms.
31 if results.failures: 30 if results.failures:
32 assert 'not supported' in failure.GetStringFromExcInfo( 31 assert 'not supported' in results.failures[0][1]
33 results.failures[0].exc_info)
34 return 32 return
35 33
36 saved_picture_count = results.FindAllPageSpecificValuesNamed( 34 saved_picture_count = results.FindAllPageSpecificValuesNamed(
37 'saved_picture_count') 35 'saved_picture_count')
38 self.assertEquals(len(saved_picture_count), 1) 36 self.assertEquals(len(saved_picture_count), 1)
39 self.assertGreater(saved_picture_count[0].GetRepresentativeNumber(), 0) 37 self.assertGreater(saved_picture_count[0].GetRepresentativeNumber(), 0)
OLDNEW
« no previous file with comments | « no previous file | trunk/src/tools/telemetry/telemetry/page/page_runner.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698