trunk/src/tools/telemetry/telemetry/results/page_measurement_results.py - Issue 393713005: Revert 284459 "Add FailureValue and wire it through PageTestResu..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: trunk/src/tools/telemetry/telemetry/results/page_measurement_results.py

Issue 393713005: Revert 284459 "Add FailureValue and wire it through PageTestResu..." (Closed) Base URL: svn://svn.chromium.org/chrome/

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: trunk/src/tools/telemetry/telemetry/results/page_measurement_results.py

===================================================================

--- trunk/src/tools/telemetry/telemetry/results/page_measurement_results.py (revision 284496)

+++ trunk/src/tools/telemetry/telemetry/results/page_measurement_results.py (working copy)

@@ -3,7 +3,6 @@

# found in the LICENSE file.

from telemetry.results import page_test_results

-from telemetry.value import failure

class PageMeasurementResults(page_test_results.PageTestResults):

def __init__(self, output_stream=None, trace_tag=''):

@@ -29,8 +28,7 @@

def AddValue(self, value):

super(PageMeasurementResults, self).AddValue(value)

- if not isinstance(value, failure.FailureValue):

- self._page_specific_values_for_current_page.append(value)

+ self._page_specific_values_for_current_page.append(value)

def DidMeasurePage(self):

assert self._current_page, 'Failed to call WillMeasurePage'