Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 314113010: Remove deprecated permissions functions from Extension (Closed)

Created:
6 years, 6 months ago by Devlin
Modified:
6 years, 6 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, vsevik, tzik, benjhayden+dwatch_chromium.org, tfarina, dbeam+watch-options_chromium.org, mcasas+watch_chromium.org, yurys, fischman+watch_chromium.org, paulirish+reviews_chromium.org, pam+watch_chromium.org, nhiroki, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, aandrey+blink_chromium.org, wjia+watch_chromium.org, kinuko+fileapi, pfeldman
Visibility:
Public.

Description

Remove deprecated permissions functions from Extension The methods GetActivePermission() and HasAPIPermission() have been deprecated for more than a year. Finally remove them. Also clean up some includes in extension.h, and fix transitive includes. BUG=379356 TBR=atwilson@chromium.org (c/b/background) TBR=yurys@chromium.org (c/b/devtools) TBR=bauerb@chromium.org (c/b/managed_mode) TBR=dalecurtis@chromium.org (c/b/media) TBR=dewittj@chromium.org (c/b/notifications) TBR=msw@chromium.org (c/b/ui) All TBRs are for strictly mechanical changes - no functional difference. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275531

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+315 lines, -197 lines) Patch
M apps/app_window.cc View 2 chunks +3 lines, -1 line 0 comments Download
M apps/saved_files_service.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/background/background_application_list_model.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/background/background_application_list_model_unittest.cc View 5 chunks +16 lines, -9 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/devtools/devtools_ui_bindings.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/active_tab_permission_granter.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/alarms/alarm_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/app_window/app_window_api.cc View 4 chunks +10 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/autotest_private/autotest_private_api.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/declarative/declarative_api.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative/rules_cache_delegate.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/file_handlers/app_file_handler_util.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_api.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/location/location_manager.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/management/management_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/messaging/message_service.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/permissions/permissions_api.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/preference/preference_api.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/preference/preference_helpers.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/push_messaging/push_messaging_api.cc View 4 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/convert_web_app_browsertest.cc View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/extensions/convert_web_app_unittest.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_disabled_ui.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_gcm_app_handler_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_install_prompt.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 6 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_special_storage_policy.cc View 5 chunks +17 lines, -8 lines 0 comments Download
M chrome/browser/extensions/extension_storage_monitor.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_tab_util.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/permissions_updater.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/permissions_updater_unittest.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/suggest_permission_util.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/managed_mode/managed_user_service.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/media/media_capture_devices_dispatcher.cc View 3 chunks +9 lines, -4 lines 0 comments Download
M chrome/browser/notifications/message_center_settings_controller.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/drive/drive_app_converter_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/content_settings_handler.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_old_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 16 chunks +28 lines, -23 lines 0 comments Download
M chrome/common/extensions/permissions/settings_override_permission_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/sync_helper.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/content_settings_observer.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M extensions/browser/api/storage/local_value_store_cache.cc View 2 chunks +3 lines, -1 line 0 comments Download
M extensions/browser/api/storage/settings_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/event_router.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M extensions/browser/info_map.h View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/info_map.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M extensions/browser/info_map_unittest.cc View 2 chunks +15 lines, -5 lines 0 comments Download
M extensions/common/extension.h View 3 chunks +0 lines, -10 lines 0 comments Download
M extensions/common/extension.cc View 2 chunks +1 line, -14 lines 0 comments Download
M extensions/common/extension_messages.cc View 1 chunk +10 lines, -5 lines 0 comments Download
M extensions/common/extension_set.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/manifest_handlers/externally_connectable_unittest.cc View 6 chunks +11 lines, -5 lines 0 comments Download
M extensions/common/manifest_handlers/shared_module_info.cc View 2 chunks +2 lines, -1 line 0 comments Download
M extensions/common/permissions/permissions_data_unittest.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M extensions/renderer/dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Devlin
I promise, we're getting close!
6 years, 6 months ago (2014-06-06 16:29:07 UTC) #1
not at google - send to devlin
lgtm
6 years, 6 months ago (2014-06-06 16:40:15 UTC) #2
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 6 months ago (2014-06-06 17:56:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/314113010/1
6 years, 6 months ago (2014-06-06 17:58:03 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 21:47:38 UTC) #5
Message was sent while issue was closed. 
Change committed as 275531

Powered by Google App Engine
This is Rietveld 408576698