chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.cc - Issue 314113010: Remove deprecated permissions functions from Extension

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.cc

Issue 314113010: Remove deprecated permissions functions from Extension (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/app_list/drive/drive_app_converter_browsertest.cc ('k') | chrome/browser/ui/webui/extensions/extension_settings_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.cc

diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.cc b/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.cc

index 62472546dc32c12e864d0335a738b8f86dd7522a..9236ebc8d31ead7c2c58cd748d6f3aa18c086472 100644

--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.cc

+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.cc

@@ -14,6 +14,7 @@

#include "extensions/common/manifest_handlers/permissions_parser.h"

#include "extensions/common/permissions/api_permission.h"

#include "extensions/common/permissions/permission_message_provider.h"

+#include "extensions/common/permissions/permissions_data.h"

#include "grit/generated_resources.h"

#include "grit/theme_resources.h"

#include "ui/base/l10n/l10n_util.h"

@@ -467,7 +468,8 @@ AppInfoPermissionsTab::GetOptionalPermissionMessages() const {

const std::vector<base::FilePath>

AppInfoPermissionsTab::GetRetainedFilePermissions() const {

std::vector<base::FilePath> retained_file_paths;

- if (app_->HasAPIPermission(extensions::APIPermission::kFileSystem)) {

+ if (app_->permissions_data()->HasAPIPermission(

+ extensions::APIPermission::kFileSystem)) {

std::vector<apps::SavedFileEntry> retained_file_entries =

apps::SavedFilesService::Get(profile_)->GetAllFileEntries(app_->id());

for (std::vector<apps::SavedFileEntry>::const_iterator it =