Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Side by Side Diff: chrome/common/extensions/permissions/settings_override_permission_unittest.cc

Issue 314113010: Remove deprecated permissions functions from Extension (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // These tests make sure SettingsOverridePermission values are set correctly. 5 // These tests make sure SettingsOverridePermission values are set correctly.
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "base/values.h" 9 #include "base/values.h"
10 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h" 10 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 manifest_keys::kSettingsOverride, settings_override.release()); 57 manifest_keys::kSettingsOverride, settings_override.release());
58 58
59 Manifest manifest(&ext_manifest, "test"); 59 Manifest manifest(&ext_manifest, "test");
60 return LoadAndExpectSuccess(manifest); 60 return LoadAndExpectSuccess(manifest);
61 } 61 }
62 }; 62 };
63 63
64 TEST_F(SettingsOverridePermissionTest, HomePage) { 64 TEST_F(SettingsOverridePermissionTest, HomePage) {
65 scoped_refptr<Extension> extension(GetPermissionSet(kHomepage)); 65 scoped_refptr<Extension> extension(GetPermissionSet(kHomepage));
66 scoped_refptr<const PermissionSet> permission_set( 66 scoped_refptr<const PermissionSet> permission_set(
67 extension->GetActivePermissions()); 67 extension->permissions_data()->active_permissions());
68 68
69 #if defined(OS_WIN) 69 #if defined(OS_WIN)
70 EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kHomepage)); 70 EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kHomepage));
71 std::vector<base::string16> warnings = 71 std::vector<base::string16> warnings =
72 extension->permissions_data()->GetPermissionMessageStrings(); 72 extension->permissions_data()->GetPermissionMessageStrings();
73 ASSERT_EQ(1u, warnings.size()); 73 ASSERT_EQ(1u, warnings.size());
74 EXPECT_EQ("Change your home page to: google.com/", 74 EXPECT_EQ("Change your home page to: google.com/",
75 base::UTF16ToUTF8(warnings[0])); 75 base::UTF16ToUTF8(warnings[0]));
76 76
77 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kStartupPages)); 77 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kStartupPages));
78 EXPECT_FALSE(permission_set->HasAPIPermission( 78 EXPECT_FALSE(permission_set->HasAPIPermission(
79 APIPermission::kSearchProvider)); 79 APIPermission::kSearchProvider));
80 #else 80 #else
81 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kHomepage)); 81 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kHomepage));
82 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kStartupPages)); 82 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kStartupPages));
83 EXPECT_FALSE( 83 EXPECT_FALSE(
84 permission_set->HasAPIPermission(APIPermission::kSearchProvider)); 84 permission_set->HasAPIPermission(APIPermission::kSearchProvider));
85 #endif 85 #endif
86 } 86 }
87 87
88 TEST_F(SettingsOverridePermissionTest, StartupPages) { 88 TEST_F(SettingsOverridePermissionTest, StartupPages) {
89 scoped_refptr<Extension> extension(GetPermissionSet(kStartupPages)); 89 scoped_refptr<Extension> extension(GetPermissionSet(kStartupPages));
90 scoped_refptr<const PermissionSet> permission_set( 90 scoped_refptr<const PermissionSet> permission_set(
91 extension->GetActivePermissions()); 91 extension->permissions_data()->active_permissions());
92 92
93 #if defined(OS_WIN) 93 #if defined(OS_WIN)
94 EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kStartupPages)); 94 EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kStartupPages));
95 std::vector<base::string16> warnings = 95 std::vector<base::string16> warnings =
96 extension->permissions_data()->GetPermissionMessageStrings(); 96 extension->permissions_data()->GetPermissionMessageStrings();
97 ASSERT_EQ(1u, warnings.size()); 97 ASSERT_EQ(1u, warnings.size());
98 EXPECT_EQ("Change your start page to: startup.com/startup.html", 98 EXPECT_EQ("Change your start page to: startup.com/startup.html",
99 base::UTF16ToUTF8(warnings[0])); 99 base::UTF16ToUTF8(warnings[0]));
100 100
101 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kHomepage)); 101 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kHomepage));
102 EXPECT_FALSE(permission_set->HasAPIPermission( 102 EXPECT_FALSE(permission_set->HasAPIPermission(
103 APIPermission::kSearchProvider)); 103 APIPermission::kSearchProvider));
104 #else 104 #else
105 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kHomepage)); 105 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kHomepage));
106 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kStartupPages)); 106 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kStartupPages));
107 EXPECT_FALSE( 107 EXPECT_FALSE(
108 permission_set->HasAPIPermission(APIPermission::kSearchProvider)); 108 permission_set->HasAPIPermission(APIPermission::kSearchProvider));
109 #endif 109 #endif
110 } 110 }
111 111
112 TEST_F(SettingsOverridePermissionTest, SearchSettings) { 112 TEST_F(SettingsOverridePermissionTest, SearchSettings) {
113 scoped_refptr<Extension> extension(GetPermissionSet(kSearchProvider)); 113 scoped_refptr<Extension> extension(GetPermissionSet(kSearchProvider));
114 scoped_refptr<const PermissionSet> permission_set( 114 scoped_refptr<const PermissionSet> permission_set(
115 extension->GetActivePermissions()); 115 extension->permissions_data()->active_permissions());
116 116
117 #if defined(OS_WIN) 117 #if defined(OS_WIN)
118 EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kSearchProvider)); 118 EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kSearchProvider));
119 std::vector<base::string16> warnings = 119 std::vector<base::string16> warnings =
120 extension->permissions_data()->GetPermissionMessageStrings(); 120 extension->permissions_data()->GetPermissionMessageStrings();
121 ASSERT_EQ(1u, warnings.size()); 121 ASSERT_EQ(1u, warnings.size());
122 EXPECT_EQ("Change your search settings to: google.com", 122 EXPECT_EQ("Change your search settings to: google.com",
123 base::UTF16ToUTF8(warnings[0])); 123 base::UTF16ToUTF8(warnings[0]));
124 124
125 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kHomepage)); 125 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kHomepage));
126 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kStartupPages)); 126 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kStartupPages));
127 #else 127 #else
128 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kHomepage)); 128 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kHomepage));
129 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kStartupPages)); 129 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kStartupPages));
130 EXPECT_FALSE( 130 EXPECT_FALSE(
131 permission_set->HasAPIPermission(APIPermission::kSearchProvider)); 131 permission_set->HasAPIPermission(APIPermission::kSearchProvider));
132 #endif 132 #endif
133 } 133 }
134 134
135 TEST_F(SettingsOverridePermissionTest, All) { 135 TEST_F(SettingsOverridePermissionTest, All) {
136 scoped_refptr<Extension> extension(GetPermissionSet( 136 scoped_refptr<Extension> extension(GetPermissionSet(
137 kSearchProvider | kStartupPages | kHomepage)); 137 kSearchProvider | kStartupPages | kHomepage));
138 scoped_refptr<const PermissionSet> permission_set( 138 scoped_refptr<const PermissionSet> permission_set(
139 extension->GetActivePermissions()); 139 extension->permissions_data()->active_permissions());
140 140
141 #if defined(OS_WIN) 141 #if defined(OS_WIN)
142 EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kSearchProvider)); 142 EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kSearchProvider));
143 EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kHomepage)); 143 EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kHomepage));
144 EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kStartupPages)); 144 EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kStartupPages));
145 #else 145 #else
146 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kHomepage)); 146 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kHomepage));
147 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kStartupPages)); 147 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kStartupPages));
148 EXPECT_FALSE( 148 EXPECT_FALSE(
149 permission_set->HasAPIPermission(APIPermission::kSearchProvider)); 149 permission_set->HasAPIPermission(APIPermission::kSearchProvider));
150 #endif 150 #endif
151 } 151 }
152 152
153 TEST_F(SettingsOverridePermissionTest, Some) { 153 TEST_F(SettingsOverridePermissionTest, Some) {
154 scoped_refptr<Extension> extension(GetPermissionSet( 154 scoped_refptr<Extension> extension(GetPermissionSet(
155 kSearchProvider | kHomepage)); 155 kSearchProvider | kHomepage));
156 scoped_refptr<const PermissionSet> permission_set( 156 scoped_refptr<const PermissionSet> permission_set(
157 extension->GetActivePermissions()); 157 extension->permissions_data()->active_permissions());
158 158
159 #if defined(OS_WIN) 159 #if defined(OS_WIN)
160 EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kSearchProvider)); 160 EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kSearchProvider));
161 EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kHomepage)); 161 EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kHomepage));
162 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kStartupPages)); 162 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kStartupPages));
163 #else 163 #else
164 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kHomepage)); 164 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kHomepage));
165 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kStartupPages)); 165 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kStartupPages));
166 EXPECT_FALSE( 166 EXPECT_FALSE(
167 permission_set->HasAPIPermission(APIPermission::kSearchProvider)); 167 permission_set->HasAPIPermission(APIPermission::kSearchProvider));
168 #endif 168 #endif
169 } 169 }
170 170
171 } // namespace 171 } // namespace
172 172
173 } // namespace extensions 173 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/common/extensions/permissions/permission_set_unittest.cc ('k') | chrome/common/extensions/sync_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698