Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1221)

Unified Diff: chrome/browser/extensions/api/downloads/downloads_api.cc

Issue 314113010: Remove deprecated permissions functions from Extension (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/downloads/downloads_api.cc
diff --git a/chrome/browser/extensions/api/downloads/downloads_api.cc b/chrome/browser/extensions/api/downloads/downloads_api.cc
index 52f113e224e3c0462b37db9be62df1b302e48c35..c34147f033ad2fc14e1bc95123321a6564f93aa3 100644
--- a/chrome/browser/extensions/api/downloads/downloads_api.cc
+++ b/chrome/browser/extensions/api/downloads/downloads_api.cc
@@ -64,6 +64,7 @@
#include "extensions/browser/extension_function_dispatcher.h"
#include "extensions/browser/extension_prefs.h"
#include "extensions/browser/extension_registry.h"
+#include "extensions/common/permissions/permissions_data.h"
#include "net/base/filename_util.h"
#include "net/base/load_flags.h"
#include "net/http/http_util.h"
@@ -1386,7 +1387,8 @@ bool DownloadsOpenFunction::RunSync() {
Fault(download_item->GetState() != DownloadItem::COMPLETE,
errors::kNotComplete,
&error_) ||
- Fault(!GetExtension()->HasAPIPermission(APIPermission::kDownloadsOpen),
+ Fault(!GetExtension()->permissions_data()->HasAPIPermission(
+ APIPermission::kDownloadsOpen),
errors::kOpenPermission,
&error_))
return false;
@@ -1431,7 +1433,8 @@ bool DownloadsSetShelfEnabledFunction::RunSync() {
scoped_ptr<downloads::SetShelfEnabled::Params> params(
downloads::SetShelfEnabled::Params::Create(*args_));
EXTENSION_FUNCTION_VALIDATE(params.get());
- if (!GetExtension()->HasAPIPermission(APIPermission::kDownloadsShelf)) {
+ if (!GetExtension()->permissions_data()->HasAPIPermission(
+ APIPermission::kDownloadsShelf)) {
error_ = download_extension_errors::kShelfPermission;
return false;
}

Powered by Google App Engine
This is Rietveld 408576698