extensions/common/permissions/permissions_data_unittest.cc - Issue 314113010: Remove deprecated permissions functions from Extension

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/permissions/permissions_data_unittest.cc

Issue 314113010: Remove deprecated permissions functions from Extension (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/permissions/permissions_data_unittest.cc

diff --git a/extensions/common/permissions/permissions_data_unittest.cc b/extensions/common/permissions/permissions_data_unittest.cc

index f7fad22953167edb19fd4a07003960367aa8033b..f9f1b6a640276b8386c925f180840eb4bd78e35f 100644

--- a/extensions/common/permissions/permissions_data_unittest.cc

+++ b/extensions/common/permissions/permissions_data_unittest.cc

@@ -133,11 +133,14 @@ TEST(ExtensionPermissionsTest, EffectiveHostPermissions) {

hosts = extension->permissions_data()->GetEffectiveHostPermissions();

EXPECT_TRUE(hosts.MatchesURL(GURL("http://google.com")));

EXPECT_TRUE(hosts.MatchesURL(GURL("http://www.reddit.com")));

- EXPECT_TRUE(extension->GetActivePermissions()->HasEffectiveAccessToURL(

- GURL("http://www.reddit.com")));

+ EXPECT_TRUE(extension->permissions_data()

+ ->active_permissions()

+ ->HasEffectiveAccessToURL(GURL("http://www.reddit.com")));

EXPECT_TRUE(hosts.MatchesURL(GURL("http://news.ycombinator.com")));

- EXPECT_TRUE(extension->GetActivePermissions()->HasEffectiveAccessToURL(

- GURL("http://news.ycombinator.com")));

+ EXPECT_TRUE(

+ extension->permissions_data()

+ ->active_permissions()

+ ->HasEffectiveAccessToURL(GURL("http://news.ycombinator.com")));

EXPECT_FALSE(extension->permissions_data()->HasEffectiveAccessToAllHosts());

extension = LoadManifest("effective_host_permissions", "all_hosts.json");